Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed empty bind group from integration example #390

Merged
merged 1 commit into from
Jun 8, 2020
Merged

Removed empty bind group from integration example #390

merged 1 commit into from
Jun 8, 2020

Conversation

derezzedex
Copy link
Member

This makes the current integration example avoid validation errors (or possible crashes) from empty bind groups that come from gfx-rs/wgpu#240.

hecrj
hecrj approved these changes Jun 8, 2020
View reviewed changes
Copy link
Member

@hecrj hecrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@hecrj hecrj added the improvement An internal improvement label Jun 8, 2020
@hecrj hecrj added this to the 0.2.0 milestone Jun 8, 2020
@hecrj hecrj merged commit 40750d9 into iced-rs:master Jun 8, 2020
@hecrj hecrj mentioned this pull request Nov 26, 2020
Merged
@derezzedex derezzedex deleted the integration-example-fix branch November 26, 2020 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hecrj hecrj hecrj approved these changes

Assignees
No one assigned
Labels
improvement An internal improvement
Projects
None yet
Milestone
0.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@derezzedex @hecrj