Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add conversion functions to Size and Vector #583

Merged
merged 2 commits into from
Oct 29, 2020
Merged

Add conversion functions to Size and Vector #583

merged 2 commits into from
Oct 29, 2020

Conversation

Limeth
Copy link
Contributor

@Limeth Limeth commented Oct 28, 2020

This PR adds conversion functions to Size and Vector for convenience.

hecrj
hecrj requested changes Oct 29, 2020
View reviewed changes
Copy link
Member

@hecrj hecrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

I think we need to address just a couple of details before merging.

core/src/vector.rs Outdated Show resolved Hide resolved
core/src/size.rs Outdated Show resolved Hide resolved
@hecrj hecrj added the improvement An internal improvement label Oct 29, 2020
@hecrj hecrj added this to the 0.2.0 milestone Oct 29, 2020
@Limeth
Copy link
Contributor Author

Limeth commented Oct 29, 2020

Thanks for the review, I applied the requested changes.

hecrj
hecrj approved these changes Oct 29, 2020
View reviewed changes
Copy link
Member

@hecrj hecrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thank you 🎉

@hecrj hecrj merged commit 820abdc into iced-rs:master Oct 29, 2020
@hecrj hecrj mentioned this pull request Nov 26, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hecrj hecrj hecrj approved these changes

Assignees
No one assigned
Labels
improvement An internal improvement
Projects
None yet
Milestone
0.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Limeth @hecrj