Add textinput focus method #598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oknozor
force-pushed
the
input-text-focus
branch
2 times, most recently
from
2af31e3
to
3249723
Compare
hecrj
force-pushed
the
input-text-focus
branch
from
de6a7be
to
1a2cb2f
Compare
hecrj
approved these changes
Nov 9, 2020
There was a problem hiding this comment.
Thanks!
I have split the focus method into focus and unfocus, instead of asking for a boolean.
I also removed the .gitignore changes. You should instead update the .git/info/exclude file in your local copy of the repository to ignore any files related to your particular environment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a small addition :
focusmethodto controlTextInput` focus state.A simple use case would be to force the focus on every call to the
Application::update, but this could be usedto move the focus around whenever a specific event occurs.