Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

This PR fixes a bug with select all (CMD + A on MacOS) when using a text_input. #605

Merged
merged 2 commits into from
Nov 25, 2020
Merged

This PR fixes a bug with select all (CMD + A on MacOS) when using a text_input. #605

merged 2 commits into from
Nov 25, 2020

Commits on Nov 25, 2020

  1. This PR fixes a bug with select all (CMD + A on MacOS) when using a t… 

    …ext_input.

Previous behaviour: when selecting all (CMD + A) would delete the current text inside the input and replace the content with just the letter 'a'.

Now we check if the logo key (modifier key) has been pressed before checking any other key and save it to the state level. This way we can prevent any text being deleted when using the select all shortcut or text being entered at all when a modifier key is pressed (this behaviour matches other text input behaviour i.e text inputs in the browser etc...).
    @ZakisM @hecrj
    ZakisM authored and hecrj committed Nov 25, 2020
    Configuration menu
    Copy the full SHA
    d275a4e View commit details
    Browse the repository at this point in the history

  2. Track keyboard modifiers in text_input

    @hecrj
    hecrj committed Nov 25, 2020
    Configuration menu
    Copy the full SHA
    1d23db1 View commit details
    Browse the repository at this point in the history