Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generic Element Content in Pane Grid TitleBar #657

Merged
merged 4 commits into from
Dec 22, 2020
Merged

Generic Element Content in Pane Grid TitleBar #657

merged 4 commits into from
Dec 22, 2020

Conversation

clarkmoody
Copy link
Contributor

Makes the TitleBar more flexible by replacing the basic string + size with a generic Element.

Not quite sure if I've connected all the dots, especially regarding events/interactions on the elements within the title content.

Upgraded the example program to have a colored Pane ID, showing off a Row containing two Text elements.

Screen Shot 2020-12-10 at 1 47 13 PM

@hecrj hecrj added the feature New feature or request label Dec 10, 2020
@hecrj hecrj added this to the 0.3.0 milestone Dec 10, 2020
hecrj added 2 commits December 22, 2020 14:44
@hecrj
Remove unnecessary text::Renderer bound for PaneGrid
f2c2f3f 
This is no longer necessary, as we do not render text directly anymore.
@hecrj
Remove unnecessary lifetime bound in TitleBar
e815c5b
hecrj
hecrj approved these changes Dec 22, 2020
View reviewed changes
Copy link
Member

@hecrj hecrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! It simplifies a bunch of code, as users can leverage the Text widget and, therefore, we can avoid rendering the title manually.

Thanks 🎉

@hecrj hecrj merged commit f8aef03 into iced-rs:master Dec 22, 2020
@hecrj hecrj mentioned this pull request Mar 31, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hecrj hecrj hecrj approved these changes

Assignees
No one assigned
Labels
feature New feature or request
Projects
None yet
Milestone
0.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@clarkmoody @hecrj @cfpgomes