Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add smol async runtime support #699

Merged
merged 5 commits into from
Jan 15, 2021
Merged

Add smol async runtime support #699

merged 5 commits into from
Jan 15, 2021

Conversation

JayceFayne
Copy link
Contributor

@JayceFayne JayceFayne commented Jan 13, 2021 •
edited
Loading

This pull adds support for the smol async runtime to iced!

@JayceFayne JayceFayne force-pushed the smol branch 2 times, most recently from 50260df to 37713f3 Compare January 13, 2021 16:22
@JayceFayne JayceFayne changed the title add smol runtime add smol async runtime Jan 13, 2021
@JayceFayne JayceFayne changed the title add smol async runtime add smol async runtime support Jan 13, 2021
@JayceFayne JayceFayne changed the title add smol async runtime support Add smol async runtime support Jan 13, 2021
@hecrj hecrj added the feature New feature or request label Jan 13, 2021
@hecrj hecrj added this to the 0.3.0 milestone Jan 13, 2021
hecrj
hecrj approved these changes Jan 15, 2021
View reviewed changes
Copy link
Member

@hecrj hecrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Glad to see that supporting smol wasn't too much of a hassle.

I made some changes to fix the time::Every implementation, as smol::Timer::interval doesn't seem to exist.

I think this should be good to go! 🍻

@hecrj hecrj merged commit 2056304 into iced-rs:master Jan 15, 2021
@JayceFayne
Copy link
Contributor Author

JayceFayne commented Jan 15, 2021 •
edited
Loading

Thanks for this! Glad to see that supporting smol wasn't too much of a hassle.

Yeah, thanks to your Executor wrapper it was actually just a few lines of code!

I made some changes to fix the time::Every implementation, as smol::Timer::interval doesn't seem to exist.

Hmm, it should exist, smol just reexports the async-io Timer implemented here 🤔

@hecrj
Copy link
Member

hecrj commented Jan 15, 2021

Hmm, it should exist, smol just reexports the async-io Timer implemented here

Yeah, my bad. Looks like I needed to run cargo update. Restored in 9da0a3d.

@JayceFayne JayceFayne deleted the smol branch January 15, 2021 20:11
@hecrj hecrj mentioned this pull request Mar 31, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hecrj hecrj hecrj approved these changes

Assignees
No one assigned
Labels
feature New feature or request
Projects
None yet
Milestone
0.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@JayceFayne @hecrj