Replies: 2 comments 1 reply
-
@Kezii Yeah there is a We could (and should) update the assets, I've started it here: #71 but the problem is the 1.12->1.13 transition incompatibly changes several asset names. So this raises the question, should we commit to supporting only 1.13+ compatible resource packs, or also 1.7-1.12 resource packs? This isn't a real problem yet but would be once we started supporting custom resource packs, #399. I'd prefer supporting both formats, so a (say) 1.7.10 user could use 1.7.10 resource packs. Looking at https://minecraft.gamepedia.com/Resource_Pack, there are even more "resource pack versions". 1.8.8 is 1, 1.9 is 2 ("due to changes in the model system, such as item tags, multipart, and changes to display tags", didn't affect us), 1.11 is 3 ("due to the change that all files should have lowercase letters", didn't matter), and 1.13 (major change) is 4. 1.15 changed to 5 ("texture mechanic changes"), 1.16.2 to 6 ("changes to wall blocks"), and upcoming 1.17 will be 7. Haven't looked into these changes in depth, but they may require other changes on our end, which could introduce more resource pack version incompatibilities. As for the fire blocks themselves, it is curious how these are shown instead of Block::Missing, I'm not sure what is going on there but it may be a bug in our update for The Flattening. Pre-flattening protocol versions, blocks are identified by their index in |
Beta Was this translation helpful? Give feedback.
-
@Kezii I investigated this problem some more, created an issue: #467 The bigger problem besides outdated assets is that block states are not stable across versions. From 1.13.2 to 1.14(.4?), new states were added so that "grass" shifted from block state 1041 to 1341, but this is not accounted for in blocks/src/lib.rs which still recognizes it as 1041 (it was slightly off due to another bug, just fixed: #468), hence the fire. steven_blocks already does calculate the block state IDs based on the possible values (ordered using the |
Beta Was this translation helpful? Give feedback.
-
Is that a compiled array with all the 1.12 blocks? Is that the reason the world is on fire when joining an 1.16 server? How can we do better?
Beta Was this translation helpful? Give feedback.
All reactions