Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.13/1.14/1.15/1.16 assets #71

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

1.13/1.14/1.15/1.16 assets #71

wants to merge 8 commits into from

Conversation

iceiix
Copy link
Owner

@iceiix iceiix commented Jan 12, 2019

(moved from iceiix/steven#71)

iceiix/steven#67 added 1.13.2 protocol support (protocol version 404) as part of #18 enhancing protocol support, but to use the new blocks, it has to be updated to use the new 1.13.x assets as well

See changes in https://minecraft.gamepedia.com/1.13/Flattening#Block_and_Item_IDs

@iceiix iceiix mentioned this pull request Jan 12, 2019
@iceiix iceiix force-pushed the master branch 3 times, most recently from c80372a to 2e99712 Compare January 12, 2019 04:44
@iceiix iceiix changed the title 1.13 assets 1.13/1.14 assets May 1, 2019
@iceiix
Copy link
Owner Author

iceiix commented May 1, 2019

Now go to 1.14 assets (#132)

@iceiix
Copy link
Owner Author

iceiix commented Aug 17, 2019

This will possibly turn out to be a large change, need to:

  • Resolve merge conflicts, rebase on master
  • Update to 14.4.4 or latest
  • Test on pre-1.13 versions

Open question: support both pre-1.13.2 and 1.13.2+ assets, is it feasible? No support for other texture packs yet, but would like to leave open the possibility of using packs matching the version of the game down to the oldest supported version (1.7.10)

@iceiix iceiix changed the title 1.13/1.14 assets 1.13/1.14/1.15 assets Jan 10, 2020
@iceiix
Copy link
Owner Author

iceiix commented Jan 10, 2020

Now that steven_blocks is fast to build (#267), it would be a good time to revisit this enhancement. By now there is another major version, 1.15 (#252). Regardless, would still like to support (or not break) support for older asset formats.

@iceiix
Copy link
Owner Author

iceiix commented Jun 21, 2020

Updated to master. The main challenge with this PR remains to be supporting both pre-1.13 and 1.13+ asset types, would not want to have to drop pre-1.13 asset compatibility because it is important for 1.7.10 - 1.12.2.

@iceiix iceiix changed the title 1.13/1.14/1.15 assets 1.13/1.14/1.15/1.16 assets Jul 4, 2020
@iceiix iceiix mentioned this pull request Dec 19, 2020
@ColdIce1605
Copy link

Anything going on with this? @iceiix

@iceiix
Copy link
Owner Author

iceiix commented Mar 4, 2021

@ColdIce1605 No updates on updating the assets, I've been putting it off mainly because it would also require defining new blocks to use the assets, by itself the change wouldn't provide much benefit, and it raises the question of (future) resource pack compatibility (ideally would like to support multiple resource pack versions - there are incompatibilities, different names)

@Bixilon
Copy link

Bixilon commented Apr 2, 2021

Why not loading the assets for all versions?

@ColdIce1605
Copy link

@iceiix I say just get rid of everything before the flattening.

@Bixilon
Copy link

Bixilon commented Apr 27, 2021

@ColdIce1605 It's not that easy. What about changed texture (names), etc? Idk how stevenarella loads the models, but that could be an issue. Also (when looking at langue files): What is with the translatable component and changed language placeholders?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants