-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.13/1.14/1.15/1.16 assets #71
base: master
Are you sure you want to change the base?
Conversation
c80372a
to
2e99712
Compare
https://minecraft.gamepedia.com/Glazed_Terracotta#History > The ID has now been changed from silver_glazed_terracotta to light_gray_glazed_terracotta.
Now go to 1.14 assets (#132) |
This will possibly turn out to be a large change, need to:
Open question: support both pre-1.13.2 and 1.13.2+ assets, is it feasible? No support for other texture packs yet, but would like to leave open the possibility of using packs matching the version of the game down to the oldest supported version (1.7.10) |
Updated to master. The main challenge with this PR remains to be supporting both pre-1.13 and 1.13+ asset types, would not want to have to drop pre-1.13 asset compatibility because it is important for 1.7.10 - 1.12.2. |
Anything going on with this? @iceiix |
@ColdIce1605 No updates on updating the assets, I've been putting it off mainly because it would also require defining new blocks to use the assets, by itself the change wouldn't provide much benefit, and it raises the question of (future) resource pack compatibility (ideally would like to support multiple resource pack versions - there are incompatibilities, different names) |
Why not loading the assets for all versions? |
@iceiix I say just get rid of everything before the flattening. |
@ColdIce1605 It's not that easy. What about changed texture (names), etc? Idk how stevenarella loads the models, but that could be an issue. Also (when looking at langue files): What is with the translatable component and changed language placeholders? |
(moved from iceiix/steven#71)
iceiix/steven#67 added 1.13.2 protocol support (protocol version 404) as part of #18 enhancing protocol support, but to use the new blocks, it has to be updated to use the new 1.13.x assets as well
See changes in https://minecraft.gamepedia.com/1.13/Flattening#Block_and_Item_IDs