Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Rust 1.58.1 #669

Merged
merged 1 commit into from
Mar 6, 2022
Merged

Update to Rust 1.58.1 #669

merged 1 commit into from
Mar 6, 2022

Conversation

iceiix
Copy link
Owner

@iceiix iceiix commented Mar 6, 2022

Using Rust 1.58.0, clippy is failing with https://rust-lang.github.io/rust-clippy/master/index.html#non_send_fields_in_send_ty

warning: this implementation is unsound, as some fields in `ConsoleProxy` are `!Send`
   --> src/console/mod.rs:455:1
    |
455 | unsafe impl Send for ConsoleProxy {}
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: `#[warn(clippy::non_send_fields_in_send_ty)]` on by default
note: the type of field `console` is `!Send`
   --> src/console/mod.rs:432:5
    |
432 |     console: Arc<Mutex<Console>>,
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    = help: use a thread-safe type that implements `Send`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_send_fields_in_send_ty

warning: `stevenarella` (lib) generated 1 warning
warning: `stevenarella` (bin "stevenarella") generated 1 warning (1 duplicate)
    Finished dev [optimized + debuginfo] target(s) in 35.17s

This clippy was disabled by default in 1.58.1: rust-lang/rust-clippy#8045

https://blog.rust-lang.org/2022/01/20/Rust-1.58.1.html

The non_send_fields_in_send_ty Clippy lint was discovered to have too many false positives and has been moved to the experimental lints group (called "nursery").

@iceiix iceiix merged commit 2fd1044 into master Mar 6, 2022
@iceiix iceiix deleted the 1.58.1 branch March 6, 2022 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant