Allow coarse location #38
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janbina
force-pushed
the
coarse-location
branch
from
61f1347
to
156776e
Compare
|
Hey @janbina, I like your change. Do you know when it will be merged? |
|
Hey @Alex009, Do you have any plan to push this change on the master in near future? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi guys, firstly, thanks for this library, it's very helpful for me!
However, one thing that was bothering me is that you always ask for
Permission.LOCATIONand there is no ability to work with coarse location.This is especially bad since on newer android versions, user is always presented with an option to only allow coarse location. This could lead to a scenario when you call
startTracking, user selects coarse location, thinking location features will start working, but they won't. And only next time you callstartTracking, user is presented with another dialog to change location access from approximate to precise.I've added an option to
allowCoarseLocationwith default valuefalse, so it should be a non-breaking change. However, I really believe thattrueshould be the default in the future, because of the aforementioned behavior.