Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WARN: Setting the fragment as the LifecycleOwner might cause memory leaks because views lives shorter than the Fragment. Consider using Fragment's view lifecycle #155

Closed
vevar opened this issue Oct 7, 2021 · 3 comments
Closed

WARN: Setting the fragment as the LifecycleOwner might cause memory leaks because views lives shorter than the Fragment. Consider using Fragment's view lifecycle #155

vevar opened this issue Oct 7, 2021 · 3 comments
Assignees
@Alex009
Labels
bug Something isn't working
Milestone
0.12.0

Comments

@vevar
Copy link

vevar commented Oct 7, 2021

moko-mvvm/mvvm-databinding/src/main/kotlin/dev/icerock/moko/mvvm/MvvmFragment.kt

Line 46 in b6f2630

binding.lifecycleOwner = this

Maybe, will be better:
binding.lifecycleOwner = viewLifecycleOwner
@Alex009 Alex009 added the bug Something isn't working label Oct 10, 2021
@Alex009
Copy link
Member

Alex009 commented Oct 10, 2021

yes, make sense

@otoo-peacemaker
Copy link

yeah..that works fine.

@Alex009 Alex009 added this to the 0.12.0 milestone Feb 11, 2022
@Alex009 Alex009 self-assigned this Feb 25, 2022
@Alex009
Copy link
Member

Alex009 commented Feb 25, 2022

will be available in 0.12.0

@Alex009 Alex009 closed this as completed Feb 25, 2022
@Alex009 Alex009 mentioned this issue Feb 25, 2022
Merged
Alex009 added a commit that referenced this issue Feb 25, 2022
@Alex009
#155 fix android potential memory leak in databinding
9f90ff3
Jasper-1024 added a commit to Jasper-1024/NoWakeLock that referenced this issue Jul 5, 2022
@Jasper-1024
Fragment's view lifecycle like -> icerockdev/moko-mvvm#155
b6e6e4b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Alex009 Alex009

Labels
bug Something isn't working
Projects
None yet
Milestone
0.12.0
Development

No branches or pull requests
3 participants
@Alex009 @vevar @otoo-peacemaker