Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support of Android Application gradle module #119

Closed
brettwillis opened this issue Oct 23, 2020 · 3 comments · Fixed by #142
Closed

Add support of Android Application gradle module #119

brettwillis opened this issue Oct 23, 2020 · 3 comments · Fixed by #142
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@brettwillis
Copy link

Hi, looks like a very useful project, I have been trying to get your project to work in my Kotlin multiplatform (Android & iOS) project. It is a single Gradle project for both apps, using Android Application plugin, not Android Library plugin.

No errors appear, but the generateMRcommonMain task is missing, and of course no resources are generated. The line below leads me to believe only library projects are supported. All your sample projects are library projects.

Why - can you not also support Android Application projects? Or please have some warning documentation to make this clear for people in the future?

@Alex009
Copy link
Member

Alex009 commented Dec 5, 2020

hello! sorry for late reply.
yes, for now we support only libraries, but i think we can add support of app modules later.

also can you describe why your multiplatform code enabled in application module, not separated library?

@Alex009 Alex009 changed the title Does this only support library projects? Add support of Android Application gradle module Dec 5, 2020
@Alex009 Alex009 added the enhancement New feature or request label Dec 5, 2020
@Alex009 Alex009 added this to the 0.14.0 milestone Dec 5, 2020
@brettwillis
Copy link
Author

Thanks.

also can you describe why your multiplatform code enabled in application module, not separated library?

I only have a single app per platform (1x Android, 1x iOS), not multiple apps per platform, so a library module is not required. The application module itself is multiplatform and I don't need an extra library module.

@Alex009 Alex009 self-assigned this Dec 29, 2020
@Alex009 Alex009 linked a pull request Jan 3, 2021 that will close this issue
Alex009 added a commit that referenced this issue Jan 3, 2021
Alex009 added a commit that referenced this issue Jan 3, 2021
…le-support

#119 android application module support
@Alex009
Copy link
Member

Alex009 commented Jan 3, 2021

will be released in 0.14.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants