Add back macOS and Windows CI #4101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
externl
requested review from
pepone and
InsertCreativityHere
and removed request for
InsertCreativityHere
pepone
reviewed
Nov 15, 2024
| { | ||
| socket.Bind(new IPEndPoint(IPAddress.IPv6Loopback, 0)); | ||
| Assert.Ignore("IPv6 is not supported on macOS"); |
There was a problem hiding this comment.
I would add a reference to the relevant bug with a TODO to revert this once the fix makes it to 8.0
pepone
approved these changes
Nov 15, 2024
pepone
pushed a commit
to pepone/icerpc-csharp
that referenced
this pull request
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were previously getting .NET hangs when testing with .NET 9 preview in CI. Now that .NET 9 is officially released we should try macOS and Windows again.