-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update viz doc to clarify its current status (partial functionality - incompatible with OA API changes) #540
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
👈 Launch a binder notebook on this branch for commit b1e9b5f I will automatically update this comment whenever this PR is modified 👈 Launch a binder notebook on this branch for commit 632ee42 👈 Launch a binder notebook on this branch for commit 9c9e722 👈 Launch a binder notebook on this branch for commit d664b80 👈 Launch a binder notebook on this branch for commit cb195f9 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## development #540 +/- ##
===============================================
- Coverage 66.05% 65.98% -0.07%
===============================================
Files 36 36
Lines 3049 3052 +3
Branches 537 538 +1
===============================================
Hits 2014 2014
- Misses 947 950 +3
Partials 88 88 ☔ View full report in Codecov by Sentry. |
Thoughts on the coverage change? The function I changed is currently not covered, but I can make it covered. I'd probably mock the response and verify a 400 raises and a 200 doesn't, but my personal feeling is there's not a ton of value there :) |
Agreed. Since #454, the broader conversation around this module is that given the lack of response to #495 and minimal complaints that this module stopped working, it may make sense to rethink how we offer any quick data visualization within icepyx. |
From #454, perhaps we can fix the notebook by updating the URL. I have no idea if the API has breaking changes or not yet 😬 EDIT: It does! Moving on... :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the updates to the warning too - thanks @mfisher87!
Thanks for the review! 🪨 ⭐ |
Related: #454