Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate pyproject.toml #557

Merged
merged 4 commits into from
Aug 18, 2024
Merged

Validate pyproject.toml #557

merged 4 commits into from
Aug 18, 2024

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Aug 13, 2024

https://github.com/tox-dev/pyproject-fmt
https://github.com/abravalheri/validate-pyproject

Also, Avoid running tests that require creds on PRs on forks by adding the changes from #563 to get CI ✅

Copy link

github-actions bot commented Aug 13, 2024

Binder 👈 Launch a binder notebook on this branch for commit 3bff82d

I will automatically update this comment whenever this PR is modified

Binder 👈 Launch a binder notebook on this branch for commit 7d841c7

Binder 👈 Launch a binder notebook on this branch for commit a251605

Binder 👈 Launch a binder notebook on this branch for commit f29d03a

Binder 👈 Launch a binder notebook on this branch for commit 55b3bf8

Binder 👈 Launch a binder notebook on this branch for commit 61b1322

Binder 👈 Launch a binder notebook on this branch for commit ef7a689

Binder 👈 Launch a binder notebook on this branch for commit 1a7c456

Binder 👈 Launch a binder notebook on this branch for commit 244c6bc

Copy link
Member

@mfisher87 mfisher87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is maybe my personal preference only, but I don't like what these formatters have done. I feel the project table should be at the top, and I feel that merging the tables together is significantly less readable than previously. I've never seen a pyproject.toml written this way before, and I've seen a lot!

That said, I'm totally in favor of a validator!

.pre-commit-config.yaml Outdated Show resolved Hide resolved
@mfisher87 mfisher87 changed the title Format and validate pyproject.toml Validate pyproject.toml Aug 13, 2024
Copy link
Member

@mfisher87 mfisher87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 LGTM!

I'd merge, but we need to figure out what's going on with Travis 😱 #558

@cclauss
Copy link
Contributor Author

cclauss commented Aug 14, 2024

we need to figure out what's going on with Travis 😱

Let's land #559 so that we can isolate those failures.

@mfisher87
Copy link
Member

Travis failures are expected and explained by #272

Sorry for the delay, let's roll :)

@mfisher87
Copy link
Member

mfisher87 commented Aug 14, 2024

Wait... shoot, I can't bypass the check, so I can't merge. I need a new permission to do that :)

Copy link

codecov bot commented Aug 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.07%. Comparing base (8ef252c) to head (244c6bc).
Report is 37 commits behind head on development.

Additional details and impacted files
@@             Coverage Diff              @@
##           development     #557   +/-   ##
============================================
  Coverage        65.07%   65.07%           
============================================
  Files               36       36           
  Lines             3052     3052           
  Branches           538      538           
============================================
  Hits              1986     1986           
  Misses             981      981           
  Partials            85       85           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cclauss
Copy link
Contributor Author

cclauss commented Aug 15, 2024

The changes from #563 make Travis CI pass but now Codecov is unhappy.

@mfisher87
Copy link
Member

Looks like I can bypass and merge when CodeCov is failing. Whew! But I won't merge until we have an approver on #563 -- don't want to circumvent any systems in place :)

.travis.yml Outdated
script: pytest icepyx/ --verbose --cov app --ignore icepyx/tests/test_behind_NSIDC_API_login.py
script: pytest icepyx/ --verbose --cov app --ignore=icepyx/tests/test_behind_NSIDC_API_login.py --ignore=icepyx/tests/test_auth.py
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be helpful for future PRs to not include changes that are in another PR (#563)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes but… It is quite useful when CI is already failing when the PR is created. PRs that fail are almost never reviewed and merged.

@cclauss cclauss requested a review from JessicaS11 August 17, 2024 05:23
@mfisher87
Copy link
Member

🚀 awesome idea!

@mfisher87 mfisher87 merged commit 118d49a into icesat2py:development Aug 18, 2024
7 checks passed
@cclauss cclauss deleted the patch-2 branch August 18, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants