-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
version 1.2.0 release #561
Conversation
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: GitHub Action <mfisher87@users.noreply.github.com>
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
Co-authored-by: Matt Fisher <mfisher87@gmail.com>
👈 Launch a binder notebook on this branch for commit c85baec I will automatically update this comment whenever this PR is modified |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #561 +/- ##
==========================================
- Coverage 66.27% 66.05% -0.23%
==========================================
Files 36 36
Lines 3072 3049 -23
Branches 537 537
==========================================
- Hits 2036 2014 -22
+ Misses 948 947 -1
Partials 88 88 ☔ View full report in Codecov by Sentry. |
My only mild concern is #562. |
So technically, the Publish to PyPI action should be ok when triggered on release because it will be pushing a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Glad to have this confirmed (that's what I thought). I just have a penchant for ending up with the cases where what should happen isn't what happens... Thanks! |
Yes, Murphy's law tends to come up during releases (and you and I both know how many times release dramas have happened before), so always good to check! |
No description provided.