Enable currently-ignored linting rules E721, E722, F403

[cclauss]

All three of these are discussed on PEP8 and should not be ignored.

E722 is https://realpython.com/the-most-diabolical-python-antipattern

[tool.ruff.lint]
ignore = [
-  # TODO: remove ignores below this line
-  # comparison syntax in tests
-  "E721",
-  # bare except
-  "E722",
-  # unable to detect undefined names
-  "F403",
]

[github-actions]

👈 Launch a binder notebook on this branch for commit 8e6a220

I will automatically update this comment whenever this PR is modified

👈 Launch a binder notebook on this branch for commit 75b2f08

[codecov]

Codecov Report

Attention: Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 65.07%. Comparing base (118d49a) to head (75b2f08).
Report is 36 commits behind head on development.

Files with missing lines	Patch %	Lines
icepyx/quest/quest.py	0.00%	2 Missing ⚠️
icepyx/quest/dataset_scripts/argo.py	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##           development     #573   +/-   ##
============================================
  Coverage        65.07%   65.07%           
============================================
  Files               36       36           
  Lines             3052     3052           
  Branches           538      538           
============================================
  Hits              1986     1986           
  Misses             981      981           
  Partials            85       85           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mfisher87]

Note: this is a test so we have automatic confirmation it's fine, but for anyone not aware, there is a difference in behavior between type(...) == ... and isintance(..., ...) - isinstance evaluates True with inheritance:

>>> class Foo(str):
...     ...
... 
>>> type(Foo()) is str
False
>>> type(Foo()) is Foo
True
>>> isinstance(Foo(), str)
True
>>> isinstance(Foo(), Foo)
True

[cclauss]

Agreed. The == --> is transition would be good enough to silence this ruff rule. The "comparing types" thing is frowned on in PEP8 and there is a different ruff rule that covers that.

[mfisher87]

The more I think about it, the more I think we should go back to exact type comparison with type(...) is .... Since this is a test, loosening the comparison enables the underlying code to change more without breaking the test. We an always come back to this. My little mind is just thinking about the "foolish consistency" part of PEP8.

Would you mind?

[mfisher87]

Awesome, thank you!

[mfisher87]

Apologies for all the mind-changing I'm doing today @cclauss. Could you address this before merge? https://github.com/icesat2py/icepyx/pull/573/files#r1722071874

[mfisher87]

Lovely! Thank you again 🙇