-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add mfisher87 as a contributor for bug, code, and 4 more #585
Conversation
👈 Launch a binder notebook on this branch for commit ed94a3f I will automatically update this comment whenever this PR is modified 👈 Launch a binder notebook on this branch for commit 7d80cbf 👈 Launch a binder notebook on this branch for commit 5696a17 👈 Launch a binder notebook on this branch for commit 1a98eb6 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## development #585 +/- ##
============================================
Coverage 65.37% 65.37%
============================================
Files 36 36
Lines 3038 3038
Branches 531 531
============================================
Hits 1986 1986
Misses 970 970
Partials 82 82 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Since I was lazy with resolving merge conflicts, now someone else needs to approve 😬 Maybe I should have just done it 😆 |
Generated with all-contributors-cli: ``` npx all-contributors-cli add mfisher87 bug,code,doc,maintenance,test,infra ```
ed94a3f
to
7d80cbf
Compare
for more information, see https://pre-commit.ci
I made the mistake of assuming that since the all contributors bot now allowed you to add multiple people at once that it would only open one PR (and thus avoid the conflict issue). I'll stick to my usual MO of only adding one person at a time and not adding anyone new until the first PR is merged. As a side note, it also mucks up the formatting of the README and requires a re-tab to fix the indentation so it renders correctly. I fixed it here so it addresses this wrong indentation introduced in #583 and #586. |
That's what I would have assumed too! |
Generated by
npx all-contributors-cli add mfisher87 bug,code,doc,maintenance,test,infra
Supercedes #584 which really annoyed me with conflicts I didn't want to deal with :)