Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add mfisher87 as a contributor for bug, code, and 4 more #585

Merged
merged 3 commits into from
Aug 23, 2024

Conversation

mfisher87
Copy link
Member

Generated by npx all-contributors-cli add mfisher87 bug,code,doc,maintenance,test,infra

Supercedes #584 which really annoyed me with conflicts I didn't want to deal with :)

Copy link

github-actions bot commented Aug 23, 2024

Binder 👈 Launch a binder notebook on this branch for commit ed94a3f

I will automatically update this comment whenever this PR is modified

Binder 👈 Launch a binder notebook on this branch for commit 7d80cbf

Binder 👈 Launch a binder notebook on this branch for commit 5696a17

Binder 👈 Launch a binder notebook on this branch for commit 1a98eb6

Copy link

codecov bot commented Aug 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.37%. Comparing base (a762ad8) to head (1a98eb6).
Report is 29 commits behind head on development.

Additional details and impacted files
@@             Coverage Diff              @@
##           development     #585   +/-   ##
============================================
  Coverage        65.37%   65.37%           
============================================
  Files               36       36           
  Lines             3038     3038           
  Branches           531      531           
============================================
  Hits              1986     1986           
  Misses             970      970           
  Partials            82       82           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@mfisher87
Copy link
Member Author

Since I was lazy with resolving merge conflicts, now someone else needs to approve 😬 Maybe I should have just done it 😆

Generated with all-contributors-cli:

```
npx all-contributors-cli add mfisher87 bug,code,doc,maintenance,test,infra
```
@JessicaS11
Copy link
Member

Supercedes #584 which really annoyed me with conflicts I didn't want to deal with :)

I made the mistake of assuming that since the all contributors bot now allowed you to add multiple people at once that it would only open one PR (and thus avoid the conflict issue). I'll stick to my usual MO of only adding one person at a time and not adding anyone new until the first PR is merged.

As a side note, it also mucks up the formatting of the README and requires a re-tab to fix the indentation so it renders correctly. I fixed it here so it addresses this wrong indentation introduced in #583 and #586.

@JessicaS11 JessicaS11 merged commit e491c84 into development Aug 23, 2024
8 checks passed
@JessicaS11 JessicaS11 deleted the allcontributors-mfisher87 branch August 23, 2024 17:23
@mfisher87
Copy link
Member Author

I made the mistake of assuming that since the all contributors bot now allowed you to add multiple people at once that it would only open one PR (and thus avoid the conflict issue)

That's what I would have assumed too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants