Extract constant URLs to own module

[mfisher87]

No description provided.

[github-actions]

👈 Launch a binder notebook on this branch for commit 2dc7e78

I will automatically update this comment whenever this PR is modified

👈 Launch a binder notebook on this branch for commit 06564c1

👈 Launch a binder notebook on this branch for commit cbaff78

[codecov]

Codecov Report

Attention: Patch coverage is 71.42857% with 4 lines in your changes missing coverage. Please review.

Project coverage is 65.56%. Comparing base (bd09d73) to head (cbaff78).
Report is 23 commits behind head on development.

Files with missing lines	Patch %	Lines
icepyx/core/granules.py	25.00%	3 Missing ⚠️
icepyx/core/is2ref.py	66.66%	1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (bd09d73) and HEAD (cbaff78). Click for more details.

HEAD has 1 upload less than BASE

Flag	BASE (bd09d73)	HEAD (cbaff78)
	3	2

Additional details and impacted files

@@               Coverage Diff               @@
##           development     #591      +/-   ##
===============================================
- Coverage        71.02%   65.56%   -5.47%     
===============================================
  Files               36       37       +1     
  Lines             3037     3043       +6     
  Branches           594      594              
===============================================
- Hits              2157     1995     -162     
- Misses             769      963     +194     
+ Partials           111       85      -26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[JessicaS11]

Having just been working on incorporating GEDI into icepyx, I'm noting that these urls are NSIDC specific even though the names are more generic. It's not a dealbreaker, but something we'll have to confront in the near future.

More generally, I didn't see any immediate analog in earthaccess, but moving towards directly using any urls that are easily surfaceable there is saving us work down the line.

[mfisher87]

Hey @JessicaS11 now that we've merged #547, can you give this another review to trigger integration tests?

[mfisher87]

Looks like something isn't right :) Looking in to it!

[JessicaS11]

Looks like something isn't right :) Looking in to it!

I'm noticing that the checks ran (successfully, and interestingly included the integration test) after the precommit auto fixes (06564c1). My approval triggered the UML auto-update (but not the integration test?), but that commit only triggered readthedocs and precommit checks. I'm guessing the status is missing because for some reason the tests weren't triggered for the head commit, but I don't quite understand why.

[mfisher87]

I especially don't understand why the unit tests weren't triggered!

[JessicaS11]

Maybe open PRs are just going to be a bit grumpy at us until we're into ones opened after the actions were implemented?

[mfisher87]

Weird. Maybe you're right and all will be fine from here!

I opened #595 in case this continues to give us trouble. I want to avoid spending too much of our limited time getting things perfect :)