fix return values for smbclient backend

icewind1991 · Apr 8, 2016 · 6e544f6 · 6e544f6
1 parent 764f3fc
commit 6e544f6
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/Share.php b/src/Share.php
@@ -370,7 +370,7 @@ protected function execute($command) {
 	 * @return bool
 	 */
 	protected function parseOutput($lines, $path = '') {
-		$this->parser->checkForError($lines, $path);
+		return $this->parser->checkForError($lines, $path);
 	}
 
 	/**

diff --git a/tests/AbstractShare.php b/tests/AbstractShare.php
@@ -207,7 +207,7 @@ public function testRenameFile($name) {
 		$this->share->put($tmpFile, $this->root . '/' . $name);
 		unlink($tmpFile);
 
-		$this->share->rename($this->root . '/' . $name, $this->root . '/' . $name . '_renamed');
+		$this->assertTrue($this->share->rename($this->root . '/' . $name, $this->root . '/' . $name . '_renamed'));
 
 		$files = $this->share->dir($this->root);
 		$this->assertEquals(1, count($files));
@@ -224,7 +224,7 @@ public function testGet($name, $text) {
 		unlink($tmpFile);
 
 		$targetFile = tempnam('/tmp', 'smb_test_');
-		$this->share->get($this->root . '/' . $name, $targetFile);
+		$this->assertTrue($this->share->get($this->root . '/' . $name, $targetFile));
 
 		$this->assertEquals($text, file_get_contents($targetFile));
 		unlink($targetFile);