Remove Date and Timestamp from supported types

closes apache#24
icexelloss · Apr 3, 2017 · b821077 · b821077
1 parent 97742b8
commit b821077
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/sql/core/src/main/scala/org/apache/spark/sql/ArrowConverters.scala b/sql/core/src/main/scala/org/apache/spark/sql/ArrowConverters.scala
@@ -144,8 +144,9 @@ private[sql] object ArrowConverters {
       case ByteType => new ArrowType.Int(8, true)
       case StringType => ArrowType.Utf8.INSTANCE
       case BinaryType => ArrowType.Binary.INSTANCE
-      case DateType => ArrowType.Date.INSTANCE
-      case TimestampType => new ArrowType.Timestamp(TimeUnit.MILLISECOND)
+      // TODO: Enable Date and Timestamp type with Arrow 0.3
+      // case DateType => ArrowType.Date.INSTANCE
+      // case TimestampType => new ArrowType.Timestamp(TimeUnit.MILLISECOND)
       case _ => throw new UnsupportedOperationException(s"Unsupported data type: $dataType")
     }
   }
@@ -411,8 +412,9 @@ private[sql] object ColumnWriter {
       case ByteType => new ByteColumnWriter(ordinal, allocator)
       case StringType => new UTF8StringColumnWriter(ordinal, allocator)
       case BinaryType => new BinaryColumnWriter(ordinal, allocator)
-      case DateType => new DateColumnWriter(ordinal, allocator)
-      case TimestampType => new TimeStampColumnWriter(ordinal, allocator)
+      // TODO: Enable Date and Timestamp type with Arrow 0.3
+      // case DateType => new DateColumnWriter(ordinal, allocator)
+      // case TimestampType => new TimeStampColumnWriter(ordinal, allocator)
       case _ => throw new UnsupportedOperationException(s"Unsupported data type: $dataType")
     }
   }

diff --git a/sql/core/src/test/scala/org/apache/spark/sql/ArrowConvertersSuite.scala b/sql/core/src/test/scala/org/apache/spark/sql/ArrowConvertersSuite.scala
@@ -91,7 +91,7 @@ class ArrowConvertersSuite extends SharedSQLContext with BeforeAndAfterAll {
     collectAndValidate(byteData)
   }
 
-  test("timestamp conversion") {
+  ignore("timestamp conversion") {
     collectAndValidate(timestampData)
   }