Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update helpdesk logic to use Jira personal access tokens #712

Merged
merged 1 commit into from
Jan 23, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 8 additions & 13 deletions .schema.env → .env.schema
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
PORT=9000
ADVERTISED_HOST=http://localhost:9000
DEBUG_LOGGING=false # turns on `debug` level logging in production

# elasticsearch
ELASTICSEARCH_HOST=http://localhost:9200
Expand Down Expand Up @@ -60,28 +61,22 @@ DONOR_AGGREGATOR_API_ROOT=
DATA_CENTER_REGISTRY_API_ROOT=

# Jira Helpdesk
JIRA_ADMIN_VAULT_CREDENTIALS_PATH =
JIRA_REST_URI =
JIRA_SERVICEDESK_ID = 9

# For local testing only, fallback values if USE_VAULT = FALSE
JIRA_ADMIN_EMAIL=
JIRA_ADMIN_PASS=

# Optional
JIRA_ORGANIZATION_ID=
JIRA_ADMIN_VAULT_CREDENTIALS_PATH=
JIRA_REST_URI=
JIRA_SERVICEDESK_ID= 9
JIRA_PERSONAL_ACCESS_TOKEN= # PAT is used only when USE_VAULT is false
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this replaces the email/pass combo. basic auth will be disabled by resIT for that API soon, and new tokens can be created using the credentials found in the argo prod vault.

JIRA_ORGANIZATION_ID= # Optional

# feature flags
FEATURE_ARRANGER_SCHEMA_ENABLED=false
FEATURE_METADATA_ACCESS_CONTROL=false
FEATURE_HELP_DESK_ENABLED=false

# recaptcha configs
## set this to true for local development if you don't want to use real recaptcha client
DEV_RECAPTCHA_DISABLED=false
DEV_RECAPTCHA_DISABLED=false # set true for stub/dev recaptcha client
RECAPTCHA_SECRET_KEY=
RECAPTCHA_VAULT_SECRET_PATH=

# system alerts
## use a JSON string. [{title:'',message:'',dismissable:true|false,id:'unique-string',alert:'warning'|'error'|'info'}]
SYSTEM_ALERTS=
SYSTEM_ALERTS=
6 changes: 3 additions & 3 deletions .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ module.exports = {
parserOptions: {
ecmaVersion: 'latest',
extraFileExtensions: ['.json'],
project: ['./tsconfig.json'],
project: ['./tsconfig.json', './tsconfig.eslint.json'],
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this adds linting for the eslint and prettier config files themselves

},
plugins: ['@typescript-eslint', 'prettier'],
root: true,
Expand Down Expand Up @@ -47,10 +47,10 @@ module.exports = {
'prettier/prettier': [
'error',
{
printWidth: 100,
trailingComma: 'all',
printWidth: 120,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updates width. update for eslint to import prettier configs to be done in separate PR.
i.e. new api with breaking changes

semi: true,
singleQuote: true,
trailingComma: 'all',
useTabs: true,
},
],
Expand Down
4 changes: 3 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,9 @@ typings/
.yarn-integrity

# dotenv environment variables file
.env
# only .env will actually be loaded
*.env*
!**/.env.schema
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this allows for local backup files, etc.


# next.js build output
.next
Expand Down
Loading