UpdateProgram in Gateway #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I opened this bug on the program service icgc-argo/program-service#145 It is not blocking this PR or issue as I have a workaround in place, but we should address that bug so we can simplify the implementation here. |
hlminh2000
approved these changes
Jul 16, 2019
| @@ -75,6 +75,21 @@ const typeDefs = gql` | |||
| admins: [ProgramUserInput!]! | |||
| } | |||
|
|
|||
| input UpdateProgramInput { | |||
| # This intentionally does not provide access to submittedDonors or genomicDonors | |||
| # Those are maintained by an internal service and should not be updated by any client through the gateway | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a hack to deal with a peculiarity of the UpdateProgram service: Before calling update, we call GetProgram to find the current values. The call to UpdateProgram provides all those values for fields that are not desired to be overwritten.
Otherwise, normal gateway service patternz...