Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix raw mode output #122

Merged
merged 4 commits into from
Dec 12, 2021
Merged

fix raw mode output #122

merged 4 commits into from
Dec 12, 2021

Conversation

ichiban
Copy link
Owner

@ichiban ichiban commented Dec 12, 2021

While reorganizing code related to streams, I ditched arbitrary io.Reader / io.Writer -backed streams.
It resulted in messed up output in cmd/1pl/main.go since it's in raw mode.

This PR fix the problem by reintroducing arbitrary io.Reader / io.Writer -backed streams.

@codecov-commenter
Copy link

codecov-commenter commented Dec 12, 2021

Codecov Report

Merging #122 (de6a6d6) into main (4be9111) will increase coverage by 0.28%.
The diff coverage is 89.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #122      +/-   ##
==========================================
+ Coverage   85.34%   85.63%   +0.28%     
==========================================
  Files          18       18              
  Lines        5049     5074      +25     
==========================================
+ Hits         4309     4345      +36     
+ Misses        658      648      -10     
+ Partials       82       81       -1     
Impacted Files Coverage Δ
engine/builtin.go 83.25% <86.44%> (+0.62%) ⬆️
engine/stream.go 100.00% <100.00%> (ø)
interpreter.go 92.22% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4be9111...de6a6d6. Read the comment docs.

@ichiban ichiban merged commit 648f8a3 into main Dec 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants