Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ditch libraries #146

Merged
merged 6 commits into from
Feb 6, 2022
Merged

Ditch libraries #146

merged 6 commits into from
Feb 6, 2022

Conversation

ichiban
Copy link
Owner

@ichiban ichiban commented Feb 5, 2022

When I introduced DCG to this library, its term expansion slowed everything down so I pushed it into an optional library.
I don't see any use cases for libraries since this is just a Go package.

  • Reimplement DCG in Go so that it doesn't slow down
  • Remove libraries

@codecov-commenter
Copy link

codecov-commenter commented Feb 5, 2022

Codecov Report

Merging #146 (3051fea) into main (3b914d7) will increase coverage by 0.29%.
The diff coverage is 97.39%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #146      +/-   ##
==========================================
+ Coverage   93.47%   93.77%   +0.29%     
==========================================
  Files          18       18              
  Lines        5092     5205     +113     
==========================================
+ Hits         4760     4881     +121     
+ Misses        284      274      -10     
- Partials       48       50       +2     
Impacted Files Coverage Δ
engine/dcg.go 95.86% <95.86%> (ø)
engine/builtin.go 90.95% <100.00%> (+0.05%) ⬆️
engine/clause.go 97.82% <100.00%> (+9.49%) ⬆️
engine/compound.go 100.00% <100.00%> (ø)
engine/vm.go 80.78% <100.00%> (+0.12%) ⬆️
interpreter.go 91.93% <100.00%> (-2.60%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b914d7...3051fea. Read the comment docs.

@ichiban ichiban merged commit ae72a14 into main Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants