Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not an expert on atomics, but my understanding is that if you're doing atomic writes on an object you need to use atomics for reads too. I changed NewVariable to use
atomic.AddUint64
's return value instead of accessing the counter variable directly.Feel free to ignore this if it's wrong. I tried to look up whether accessing global value types non-atomically after atomic writes was safe or not but I couldn't find much, but my gut instinct is that it's probably best avoided 🤔