Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add backwards compatibility for nvim 0.9 #10

Merged
merged 4 commits into from
Mar 10, 2024
Merged

fix: add backwards compatibility for nvim 0.9 #10

merged 4 commits into from
Mar 10, 2024

Conversation

chrisgrieser
Copy link
Contributor

No description provided.

@icholy
Copy link
Owner

icholy commented Mar 10, 2024

Thanks for opening this, I really appreciate it.

@chrisgrieser
Copy link
Contributor Author

btw, if you add a stylua.toml and/or .editorconfig, such formatting issues would be much easier to catch 🙏

@icholy
Copy link
Owner

icholy commented Mar 10, 2024

I have a .luacheckrc at the root. Is stylua the more commonly used tool?

@icholy
Copy link
Owner

icholy commented Mar 10, 2024

I just tested your fork and 0.9 doesn't seem to have vim.lsp.get_clients. I think we'll need to use vim.lsp.buf_get_clients instead. I can do that myself if you don't feel like it though, so let me know.

edit: I'll change the call after merging this.

@icholy icholy merged commit cdf9aa4 into icholy:master Mar 10, 2024
1 check passed
@chrisgrieser
Copy link
Contributor Author

I have a .luacheckrc at the root. Is stylua the more commonly used tool?

Yes, by far. Among other things, the last luacheck commit was 6 years ago.

@icholy
Copy link
Owner

icholy commented Mar 10, 2024

@chrisgrieser does the lua/neovim community have a convention for indentation?

@chrisgrieser
Copy link
Contributor Author

@icholy not that I know of. I think every plugin author decides themselves, and sets that in their config file, I think. Adding an .editorconfig (supported by neovim core) is and a .stylua.toml as the most popular lua formatter should be enough from what I can tell.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants