rocm: fix bug in intercept mode path #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcongiu
force-pushed
the
2023.10.27_fix-intercept-mode-bug
branch
from
b3af898 to
1c4cc1c
Compare
gcongiu
force-pushed
the
2023.10.27_fix-intercept-mode-bug
branch
from
1c4cc1c to
c1c8b7f
Compare
adanalis
approved these changes
Nov 9, 2023
gcongiu
force-pushed
the
2023.10.27_fix-intercept-mode-bug
branch
from
c1c8b7f to
b1912af
Compare
The intercept mode path keeps track of incercepted events using the same hash table used to map event names to entries in the native event table. The event names don't collide because intercept mode keeps track of the base name of the event (discarding device id and instance number), while native event table entries are referenced as "name:device=N:instance=M". The reason is that events are intercepted on all devices' dispatch queues regarless the device id specified by the user (this approach follows rocprof strategy). However, using only the event name without the instance number will cause problems. Instances represent separate events and should not be treated as a single event. The proposed patch uses a separate has table for intercept mode and inserts the feature name rather than the event base name. This means that events with more than one instance will have an hash table key of the form "name[M]", where M represents the instance. If the event only has one instance the key will be "name".
gcongiu
force-pushed
the
2023.10.27_fix-intercept-mode-bug
branch
from
b1912af to
01eae41
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
The intercept mode path keeps track of events of intercepted kernel using the same hash table used to map event names to entries in the native event table (hash table normally used to do
ntv_name_to_codeconversions). The event names in the hash table don't collide because intercept mode keeps track of the base name of the event (discarding device and instance number), while native event table entries are referenced throughname:device=N:instance=Mkeys.The reason for storing only the name of the event in intercept mode is that events are set up on all devices' dispatch queues, regardless the device specified by the user (this approach follows
rocprofstrategy). However, using only the event name without the instance number will cause problems. Instances represent separate events and should not be treated as a single event (XXXX:instance=2 != XXXX:instance=3).The proposed patch uses a separate hash table for intercept mode and inserts the feature name rather than the event base name. This means that events with more than one instance will have a hash table key of the form
name[M], where M represents the instance number. If the event only has one instance the key will bename.Author Checklist
Why this PR exists. Reference all relevant information, including background, issues, test failures, etc
Commits are self contained and only do one thing
Commits have a header of the form:
module: short descriptionCommits have a body (whenever relevant) containing a detailed description of the addressed problem and its solution
The PR needs to pass all the tests