This repository has been archived by the owner on Jan 2, 2023. It is now read-only.
Fixing bug with appending varint of 0. #112
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great, thanks. Feels like I should have had a test for zero, seems obvious in hindsight. I'll merge shortly. Do you need a new version released soon? |
|
You're welcome! Soon would be ideal, but we are not in a huge rush either. |
|
I changed the fix around a bit and added a separate test for I'll release v2.0.1 shortly. |
|
I've pushed v2.0.1 to RubyGems now. |
|
Great! Thank you for the quick response! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our team discovered an issue with saving a BigDecimal value of "0.0". We found that the append_varint method in cql_byte_buffer.rb doesn't encode the number 0. This commit fixes append_varint, fixing the usage of BigDecimal "0.0".