-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SVG Injector doesn't work if there is a URL parameter #17
Comments
…meter". Updated the regex that was matching for an svg file extension to allow for query strings.
Fixed this by updating the regex that was matching the SVG file extension to allow for query strings. Adding a version # query string to assets is a common cache-busting technique used by CDNs (including Shopify). |
@protodave is this already included in the current iconic.js? It seems not to work. |
Not yet, but It'll be in the next Iconic release, v1.7.0, which is almost ready. If you want the updated iconic.js sooner just shoot me an email to yourfriends -at- useiconic.com and I'll sent it to you! |
@protodave Thanks Dave. I temporary added the fix myself to the minified iconic.js (since it's really to update the regex). I'm okay with waiting for the official release. |
Ok, great, thanks. The new Iconic release should be out in the next couple of days. |
The text was updated successfully, but these errors were encountered: