-
-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v1.0 Integration work #200
Merged
mikeskydev
merged 202 commits into
icosa-foundation:main
from
IxxyXR:features/moatmerge-plusPR198
Dec 5, 2021
Merged
v1.0 Integration work #200
mikeskydev
merged 202 commits into
icosa-foundation:main
from
IxxyXR:features/moatmerge-plusPR198
Dec 5, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[CI BUILD]
[CI BUILD]
…d add more turtles. I like turtles. [CI BUILD]
In order to make it easier to run multiple versions, instead of a fixed "-github" name (and package name of com.icosa.openbrushgithub), this commit changes the logic for CI builds. * Builds from PRs are named PR#xx (PRxx in the package name) * Builds from branches (triggered with a [CI BUILD] tag) are named based on the branch name. Special characters of /[#_-]/ are removed from the package name * All commits on main have the same name, whether they're pre-release builds or formal release builds. This means that the pre-release builds will NOT have a unique name, but this will allow us to upload them to a "beta" release channel
[CI BUILD]
[CI BUILD]
[CI BUILD]
[CI BUILD]
[CI BUILD]
[CI BUILD]
…ands to endpoints where appropriate. [CI BUILD]
…PI listing command.
…w bugs with the html examples. [CI BUILD]
[CI BUILD]
…moatmerge-plusPR198
…ferences to moat's grid snapping
…rging brush strokes" This reverts commit 8c44db9.
mikeskydev
requested changes
Dec 3, 2021
mikeage
approved these changes
Dec 5, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to work for me. So all I can do is link to https://twitter.com/iamdevloper/status/397664295875805184
mikeskydev
approved these changes
Dec 5, 2021
This was referenced Dec 5, 2021
Closed
Closed
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integration PR containing:
https://www.youtube.com/watch?v=_d34eBiTtGA
https://www.youtube.com/watch?v=2CEyUrv3IZk
https://www.youtube.com/watch?v=ufGpqmul4Rc
https://www.youtube.com/watch?v=Wtx5uAF0GXs
https://www.youtube.com/watch?v=qJf4Wsu_EJA
Closes #154, #155, #165, #186, #187, #199