Use GLTFast as the primary load; fall back to the old code if it fails

[andybak]

Use GLTFast as the importer and fall back to the old code if GltfImport.Load() fails. Tested on most of the Kronos GLTF 2.0 samples. Apart from some more obscure examples, they all seem to import fine.

Current known bugs:

1. If you save a scene and reload it, gltfs are missing initially. Loading the scene a second time works
2. Importing point clouds seems to be broken
3. API command for importing models isn't working (code was accidentally removed but added it back in and it still fails
4. App freezes sometimes when importing a model via UI

[mikeskydev]

Will do a proper review, but are the sample files and the changes to Main.unity needed? similarly, the shader includes, but I could see that being needed more. are those includes copied directly from glTFast or have they been altered somehow?

[andybak]

[are] the changes to Main.unity needed?

I can answer this bit. Pretty sure those are the same changes you'd see if you save Main.unity on the xr_vr branch. Just Unity being Unity.

[andybak]

but are the sample files [..] needed? similarly, the shader includes, but I could see that being needed more. are those includes copied directly from glTFast or have they been altered somehow?

@omn0mn0m - you're probably better placed to answer this bit. I haven't looked too closely at samples or shader files.

[omn0mn0m]

Will do a proper review, but are the sample files and the changes to Main.unity needed? similarly, the shader includes, but I could see that being needed more. are those includes copied directly from glTFast or have they been altered somehow?

The sample models were just for me testing with glb files. Sorry, forgot to delete them.

This might be my lack of unity knowledge, but I wasn't able to make .shadervariants without copying the .shader files locally. I figured there should be a way to do it, but could not find it.

[andybak]

Not sure where you are with the other cleanups but I think point cloud import is now broken. I think that's a blocker as that's an existing, announced feature.

It seems to get as far as creating the gameobject but then doesn't convert into a prefab (or give an error)

[andybak]

Taking this out of draft mode. In my opinion the remaining API bug can be fixed after merging to main or shortly after. At the very least this is ready for review and further testing.

[mikeage]

Are the compilation failures legitimate, or a temporary problem on the server side?

[andybak]

Sometimes hard to discern which errors are actually causing the failure. I think it's this part:

An error occurred while resolving packages: Project has invalid dependencies: org.nuget.google.apis: Package [org.nuget.google.apis@1.57.0] cannot be found org.nuget.google.apis.auth: Package [org.nuget.google.apis.auth@1.57.0] cannot be found org.nuget.sharpziplib: Package [org.nuget.sharpziplib@1.3.1] cannot be found

I am assuming they are spurious because none of that is specific to this branch.

[mikeage]

Sometimes hard to discern which errors are actually causing the failure. I think it's this part:

An error occurred while resolving packages: Project has invalid dependencies: org.nuget.google.apis: Package [org.nuget.google.apis@1.57.0] cannot be found org.nuget.google.apis.auth: Package [org.nuget.google.apis.auth@1.57.0] cannot be found org.nuget.sharpziplib: Package [org.nuget.sharpziplib@1.3.1] cannot be found

I am assuming they are spurious because none of that is specific to this branch.

I assumed, but I saw that there were changes to the packages file and just wanted to make sure that these weren't dependencies or anything like that. In any case, looks good now!