Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset eye texture scale to 1 #430

Merged
merged 1 commit into from
Apr 18, 2023
Merged

Reset eye texture scale to 1 #430

merged 1 commit into from
Apr 18, 2023

Conversation

mikeskydev
Copy link
Member

Was previously at 0.9 on all quality levels, meaning we ran below native res on mobile platforms.

@mikeskydev mikeskydev requested a review from andybak April 18, 2023 08:38
@TimAidley
Copy link
Contributor

The 0.9 was chosen to maintain performance on Quest 1 - I think it's probably all right to move it to 1 now, as the majority of devices will be Quest 2s.

More generally, I've been thinking about how we should probably add quality settings back in to the mobile build, so that you can do things like force bloom to stay on, and turn on shadows.

@mikeskydev
Copy link
Member Author

I agree! Giving more flexibility will help users get the most out of their hardware depending on the complexity of their sketch. Additionally, we seemed to have improved performance on the Quest 1 during XR upgrades, so it should still be able to cope well enough with this change.

@mikeage
Copy link
Member

mikeage commented Apr 18, 2023

Just as a reminder, we may have improved performance, but we also destroyed battery life :-/

@mikeskydev
Copy link
Member Author

Yes, I would love to check how much of that is our own XR changes and how much is just upgrading the oculus package!

@mikeskydev mikeskydev merged commit ecd8053 into main Apr 18, 2023
@mikeskydev mikeskydev deleted the fix/eye-tex-scale branch April 18, 2023 20:40
@mikeskydev mikeskydev added the enhancement Feature added label Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature added
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants