Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #3251: Decompiler Settings: Checkbox in group header does not reflect state of the group #3252

Merged
merged 3 commits into from
Aug 8, 2024

Conversation

tom-englert
Copy link
Contributor

@tom-englert tom-englert commented Aug 3, 2024

Fixes #3251 #3249
Supersedes #3250

Problem

Decompiler Settings: Checkbox in group header does not reflect state of the group

Solution

  • Move the logic from UI to ViewModel, and implement it following WPF best practices .
  • At least one test covering the code changed => Xaml is not covered by tests

@siegfriedpammer
Copy link
Member

siegfriedpammer commented Aug 3, 2024

If this PR supersedes the other PR... can you please close the other PR? Thanks!

@siegfriedpammer siegfriedpammer merged commit fa0ab07 into icsharpcode:master Aug 8, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Decompiler Settings: Checkbox in group header does not reflect state of the group
2 participants