Replace RuntimeHelpers.CreateSpan<T>(LdMemberToken) with new T[] { }
#3380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ds5678
commented
Jan 24, 2025
Comment on lines
+378
to
+389
| #if !NET40 && ROSLYN | ||
| public static ReadOnlySpan<byte> ReadOnlySpanInitializer_ByteArray() | ||
| { | ||
| return new byte[] { 1, 2, 3 }; | ||
| } | ||
|
|
||
| public static ReadOnlySpan<int> ReadOnlySpanInitializer_Int32Array() | ||
| { | ||
| return new int[] { 1, 2, 3 }; | ||
| } | ||
| #endif | ||
|
|
There was a problem hiding this comment.
Should I have put these in a new file and modified the options? It currently fails for Roslyn v1.
ds5678
commented
Jan 24, 2025
| @@ -143,6 +143,40 @@ internal static bool TransformSpanTArrayInitialization(NewObj inst, StatementTra | |||
| return false; | |||
| } | |||
|
|
|||
| internal static bool TransformRuntimeHelpersCreateSpanInitialization(Call inst, StatementTransformContext context, out ILInstruction replacement) | |||
ds5678
commented
Jan 24, 2025
Comment on lines
+162
to
+174
| if (context.Settings.Utf8StringLiterals && | ||
| elementType.IsKnownType(KnownTypeCode.Byte) && | ||
| DecodeUTF8String(initialValue, size, out string text)) | ||
| { | ||
| replacement = new LdStrUtf8(text); | ||
| return true; | ||
| } | ||
| if (DecodeArrayInitializer(elementType, initialValue, new[] { size }, valuesList)) | ||
| { | ||
| var tempStore = context.Function.RegisterVariable(VariableKind.InitializerTarget, new ArrayType(context.TypeSystem, elementType)); | ||
| replacement = BlockFromInitializer(tempStore, elementType, new[] { size }, valuesList.ToArray()); | ||
| return true; | ||
| } |
There was a problem hiding this comment.
This is the same as for Span<T>(void*, int) handler. Should split this out into a shared function?
ds5678
commented
Jan 24, 2025
| field = default; | ||
| elementType = null; | ||
| IType type = inst.Method.DeclaringType; | ||
| if (type.Namespace != "System.Runtime.CompilerServices" || type.Name != "RuntimeHelpers" || type.TypeParameterCount != 0) |
There was a problem hiding this comment.
Is this the right way to check? Should I have created a "known" type?
ds5678
commented
Jan 24, 2025
Comment on lines
+231
to
+235
| if (inst.Arguments.Count != 1) | ||
| return false; | ||
| IMethod method = inst.Method; | ||
| if (method.Name != "CreateSpan" || method.TypeArguments.Count != 1) | ||
| return false; |
There was a problem hiding this comment.
Should I be checking the full method signature? I noticed that the other handler doesn't check argument types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Resolves #3379
Solution
Span<T>(void*, int).