Add support for Filename field in GZip #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piksel
commented
Aug 16, 2020
Comment on lines
-289
to
-293
| if (readByte < 0) | ||
| { | ||
| throw new EndOfStreamException("EOS reading GZIP header"); | ||
| } |
There was a problem hiding this comment.
ReadLeByte() never returns anything but a byte, it will itself throw an exception in the case of an EOS
Codecov Report
@@ Coverage Diff @@
## master #351 +/- ##
==========================================
+ Coverage 73.13% 73.25% +0.12%
==========================================
Files 68 68
Lines 8710 8712 +2
==========================================
+ Hits 6370 6382 +12
+ Misses 2340 2330 -10
Continue to review full report at Codecov.
|
HowToDoThis
added a commit
to HowToDoThis/SharpZipLib
that referenced
this pull request
Aug 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I certify that I own, and have sufficient rights to contribute, all source code and related material intended to be compiled or integrated with the source code for the SharpZipLib open source product (the "Contribution"). My Contribution is licensed under the MIT License.