Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICTSC2024 メンバー追加 #214

Merged
merged 2 commits into from
Jun 15, 2024
Merged

ICTSC2024 メンバー追加 #214

merged 2 commits into from
Jun 15, 2024

Conversation

mu-ruU1
Copy link
Member

@mu-ruU1 mu-ruU1 commented May 27, 2024

No description provided.

@mu-ruU1 mu-ruU1 requested review from onokatio and Crow314 May 27, 2024 14:17
Copy link

Terraform Plan

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  + create
  ~ update in-place

Terraform will perform the following actions:

  # github_membership.member["210on"] will be created
  + resource "github_membership" "member" {
      + etag     = (known after apply)
      + id       = (known after apply)
      + role     = "member"
      + username = "210on"
    }

  # github_membership.member["Dodai-Dodai"] will be created
  + resource "github_membership" "member" {
      + etag     = (known after apply)
      + id       = (known after apply)
      + role     = "member"
      + username = "Dodai-Dodai"
    }

  # github_membership.member["I1da725"] will be created
  + resource "github_membership" "member" {
      + etag     = (known after apply)
      + id       = (known after apply)
      + role     = "member"
      + username = "I1da725"
    }

  # github_membership.member["Yosshi72"] will be created
  + resource "github_membership" "member" {
      + etag     = (known after apply)
      + id       = (known after apply)
      + role     = "member"
      + username = "Yosshi72"
    }

  # github_membership.member["hitto-hub"] will be created
  + resource "github_membership" "member" {
      + etag     = (known after apply)
      + id       = (known after apply)
      + role     = "member"
      + username = "hitto-hub"
    }

  # github_membership.member["kerthical"] will be created
  + resource "github_membership" "member" {
      + etag     = (known after apply)
      + id       = (known after apply)
      + role     = "member"
      + username = "kerthical"
    }

  # github_membership.member["konkichi836"] will be created
  + resource "github_membership" "member" {
      + etag     = (known after apply)
      + id       = (known after apply)
      + role     = "member"
      + username = "konkichi836"
    }

  # github_membership.member["kouxi08"] will be created
  + resource "github_membership" "member" {
      + etag     = (known after apply)
      + id       = (known after apply)
      + role     = "member"
      + username = "kouxi08"
    }

  # github_membership.member["meronpannn"] will be created
  + resource "github_membership" "member" {
      + etag     = (known after apply)
      + id       = (known after apply)
      + role     = "member"
      + username = "meronpannn"
    }

  # github_membership.member["onabe3"] will be created
  + resource "github_membership" "member" {
      + etag     = (known after apply)
      + id       = (known after apply)
      + role     = "member"
      + username = "onabe3"
    }

  # github_membership.member["private-yusuke"] will be created
  + resource "github_membership" "member" {
      + etag     = (known after apply)
      + id       = (known after apply)
      + role     = "member"
      + username = "private-yusuke"
    }

  # github_membership.member["shou3008"] will be created
  + resource "github_membership" "member" {
      + etag     = (known after apply)
      + id       = (known after apply)
      + role     = "member"
      + username = "shou3008"
    }

  # github_membership.member["shuumai587"] will be created
  + resource "github_membership" "member" {
      + etag     = (known after apply)
      + id       = (known after apply)
      + role     = "member"
      + username = "shuumai587"
    }

  # github_membership.member["takato256"] will be created
  + resource "github_membership" "member" {
      + etag     = (known after apply)
      + id       = (known after apply)
      + role     = "member"
      + username = "takato256"
    }

  # github_membership.member["tosuke"] will be created
  + resource "github_membership" "member" {
      + etag     = (known after apply)
      + id       = (known after apply)
      + role     = "member"
      + username = "tosuke"
    }

  # github_team.team["ictsc2024"] will be created
  + resource "github_team" "team" {
      + create_default_maintainer = false
      + description               = "member of ictsc2024"
      + etag                      = (known after apply)
      + id                        = (known after apply)
      + members_count             = (known after apply)
      + name                      = "ictsc2024"
      + node_id                   = (known after apply)
      + privacy                   = "closed"
      + slug                      = (known after apply)
    }

  # github_team_members.team_member["Admins"] will be updated in-place
  ~ resource "github_team_members" "team_member" {
        id      = "2008807"
        # (2 unchanged attributes hidden)

      - members {
          - role     = "member" -> null
          - username = "ecodrive-18" -> null
        }

        # (17 unchanged blocks hidden)
    }

  # github_team_members.team_member["ictsc2023"] will be updated in-place
  ~ resource "github_team_members" "team_member" {
        id      = "8186988"
        # (2 unchanged attributes hidden)

      - members {
          - role     = "member" -> null
          - username = "asahi-time" -> null
        }
      + members {
          + role     = "member"
          + username = "ecodrive-18"
        }
      + members {
          + role     = "member"
          + username = "meronpannn"
        }
      + members {
          + role     = "member"
          + username = "shuumai587"
        }
      - members {
          - role     = "member" -> null
          - username = "syuuya-nakatomi" -> null
        }

        # (10 unchanged blocks hidden)
    }

  # github_team_members.team_member["ictsc2024"] will be created
  + resource "github_team_members" "team_member" {
      + etag    = (known after apply)
      + id      = (known after apply)
      + team_id = (known after apply)

      + members {
          + role     = "maintainer"
          + username = "Crow314"
        }
      + members {
          + role     = "maintainer"
          + username = "Nishinoyama"
        }
      + members {
          + role     = "maintainer"
          + username = "logica0419"
        }
      + members {
          + role     = "maintainer"
          + username = "onokatio"
        }
      + members {
          + role     = "maintainer"
          + username = "x86taka"
        }
      + members {
          + role     = "member"
          + username = "210on"
        }
      + members {
          + role     = "member"
          + username = "Art-Atlas"
        }
      + members {
          + role     = "member"
          + username = "Dodai-Dodai"
        }
      + members {
          + role     = "member"
          + username = "Fuuma0000"
        }
      + members {
          + role     = "member"
          + username = "I1da725"
        }
      + members {
          + role     = "member"
          + username = "Yosshi72"
        }
      + members {
          + role     = "member"
          + username = "flora058x"
        }
      + members {
          + role     = "member"
          + username = "hitto-hub"
        }
      + members {
          + role     = "member"
          + username = "kerthical"
        }
      + members {
          + role     = "member"
          + username = "konkichi836"
        }
      + members {
          + role     = "member"
          + username = "kouxi08"
        }
      + members {
          + role     = "member"
          + username = "mu-ruU1"
        }
      + members {
          + role     = "member"
          + username = "onabe3"
        }
      + members {
          + role     = "member"
          + username = "private-yusuke"
        }
      + members {
          + role     = "member"
          + username = "shou3008"
        }
      + members {
          + role     = "member"
          + username = "syuuya-nakatomi"
        }
      + members {
          + role     = "member"
          + username = "takato256"
        }
      + members {
          + role     = "member"
          + username = "tosuke"
        }
    }

Plan: 17 to add, 2 to change, 0 to destroy.

─────────────────────────────────────────────────────────────────────────────

Note: You didn't use the -out option to save this plan, so Terraform can't
guarantee to take exactly these actions if you run "terraform apply" now.

@mu-ruU1
Copy link
Member Author

mu-ruU1 commented May 27, 2024

planを見る限り問題はなさそう

@Crow314 Crow314 requested a review from Nishinoyama May 28, 2024 06:33
@Nishinoyama
Copy link
Contributor

追加メンバーLGTM

髙貝さんもインフラリーダーになるんだったら、maintainer に昇格しちゃっても良い気がします。

https://github.com/ictsc/ictsc-github-member/blob/fb63fd7a69cfc319f4c5878aa58eae4861e4a090/team-admin.tf

Copy link

Terraform Plan

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  + create
  ~ update in-place

Terraform will perform the following actions:

  # github_membership.member["210on"] will be created
  + resource "github_membership" "member" {
      + etag     = (known after apply)
      + id       = (known after apply)
      + role     = "member"
      + username = "210on"
    }

  # github_membership.member["Dodai-Dodai"] will be created
  + resource "github_membership" "member" {
      + etag     = (known after apply)
      + id       = (known after apply)
      + role     = "member"
      + username = "Dodai-Dodai"
    }

  # github_membership.member["I1da725"] will be created
  + resource "github_membership" "member" {
      + etag     = (known after apply)
      + id       = (known after apply)
      + role     = "member"
      + username = "I1da725"
    }

  # github_membership.member["Yosshi72"] will be created
  + resource "github_membership" "member" {
      + etag     = (known after apply)
      + id       = (known after apply)
      + role     = "member"
      + username = "Yosshi72"
    }

  # github_membership.member["hitto-hub"] will be created
  + resource "github_membership" "member" {
      + etag     = (known after apply)
      + id       = (known after apply)
      + role     = "member"
      + username = "hitto-hub"
    }

  # github_membership.member["kerthical"] will be created
  + resource "github_membership" "member" {
      + etag     = (known after apply)
      + id       = (known after apply)
      + role     = "member"
      + username = "kerthical"
    }

  # github_membership.member["konkichi836"] will be created
  + resource "github_membership" "member" {
      + etag     = (known after apply)
      + id       = (known after apply)
      + role     = "member"
      + username = "konkichi836"
    }

  # github_membership.member["kouxi08"] will be created
  + resource "github_membership" "member" {
      + etag     = (known after apply)
      + id       = (known after apply)
      + role     = "member"
      + username = "kouxi08"
    }

  # github_membership.member["meronpannn"] will be created
  + resource "github_membership" "member" {
      + etag     = (known after apply)
      + id       = (known after apply)
      + role     = "member"
      + username = "meronpannn"
    }

  # github_membership.member["mu-ruU1"] will be updated in-place
  ~ resource "github_membership" "member" {
        id       = "ictsc:mu-ruU1"
      ~ role     = "member" -> "admin"
        # (2 unchanged attributes hidden)
    }

  # github_membership.member["onabe3"] will be created
  + resource "github_membership" "member" {
      + etag     = (known after apply)
      + id       = (known after apply)
      + role     = "member"
      + username = "onabe3"
    }

  # github_membership.member["private-yusuke"] will be created
  + resource "github_membership" "member" {
      + etag     = (known after apply)
      + id       = (known after apply)
      + role     = "member"
      + username = "private-yusuke"
    }

  # github_membership.member["shou3008"] will be created
  + resource "github_membership" "member" {
      + etag     = (known after apply)
      + id       = (known after apply)
      + role     = "member"
      + username = "shou3008"
    }

  # github_membership.member["shuumai587"] will be created
  + resource "github_membership" "member" {
      + etag     = (known after apply)
      + id       = (known after apply)
      + role     = "member"
      + username = "shuumai587"
    }

  # github_membership.member["takato256"] will be created
  + resource "github_membership" "member" {
      + etag     = (known after apply)
      + id       = (known after apply)
      + role     = "member"
      + username = "takato256"
    }

  # github_membership.member["tosuke"] will be created
  + resource "github_membership" "member" {
      + etag     = (known after apply)
      + id       = (known after apply)
      + role     = "member"
      + username = "tosuke"
    }

  # github_team.team["ictsc2024"] will be created
  + resource "github_team" "team" {
      + create_default_maintainer = false
      + description               = "member of ictsc2024"
      + etag                      = (known after apply)
      + id                        = (known after apply)
      + members_count             = (known after apply)
      + name                      = "ictsc2024"
      + node_id                   = (known after apply)
      + privacy                   = "closed"
      + slug                      = (known after apply)
    }

  # github_team_members.team_member["Admins"] will be updated in-place
  ~ resource "github_team_members" "team_member" {
        id      = "2008807"
        # (2 unchanged attributes hidden)

      + members {
          + role     = "maintainer"
          + username = "mu-ruU1"
        }
      - members {
          - role     = "member" -> null
          - username = "ecodrive-18" -> null
        }

        # (17 unchanged blocks hidden)
    }

  # github_team_members.team_member["ictsc2023"] will be updated in-place
  ~ resource "github_team_members" "team_member" {
        id      = "8186988"
        # (2 unchanged attributes hidden)

      + members {
          + role     = "maintainer"
          + username = "mu-ruU1"
        }
      - members {
          - role     = "member" -> null
          - username = "asahi-time" -> null
        }
      + members {
          + role     = "member"
          + username = "ecodrive-18"
        }
      + members {
          + role     = "member"
          + username = "meronpannn"
        }
      - members {
          - role     = "member" -> null
          - username = "mu-ruU1" -> null
        }
      + members {
          + role     = "member"
          + username = "shuumai587"
        }
      - members {
          - role     = "member" -> null
          - username = "syuuya-nakatomi" -> null
        }

        # (9 unchanged blocks hidden)
    }

  # github_team_members.team_member["ictsc2024"] will be created
  + resource "github_team_members" "team_member" {
      + etag    = (known after apply)
      + id      = (known after apply)
      + team_id = (known after apply)

      + members {
          + role     = "maintainer"
          + username = "Crow314"
        }
      + members {
          + role     = "maintainer"
          + username = "Nishinoyama"
        }
      + members {
          + role     = "maintainer"
          + username = "logica0419"
        }
      + members {
          + role     = "maintainer"
          + username = "mu-ruU1"
        }
      + members {
          + role     = "maintainer"
          + username = "onokatio"
        }
      + members {
          + role     = "maintainer"
          + username = "x86taka"
        }
      + members {
          + role     = "member"
          + username = "210on"
        }
      + members {
          + role     = "member"
          + username = "Art-Atlas"
        }
      + members {
          + role     = "member"
          + username = "Dodai-Dodai"
        }
      + members {
          + role     = "member"
          + username = "Fuuma0000"
        }
      + members {
          + role     = "member"
          + username = "I1da725"
        }
      + members {
          + role     = "member"
          + username = "Yosshi72"
        }
      + members {
          + role     = "member"
          + username = "flora058x"
        }
      + members {
          + role     = "member"
          + username = "hitto-hub"
        }
      + members {
          + role     = "member"
          + username = "kerthical"
        }
      + members {
          + role     = "member"
          + username = "konkichi836"
        }
      + members {
          + role     = "member"
          + username = "kouxi08"
        }
      + members {
          + role     = "member"
          + username = "onabe3"
        }
      + members {
          + role     = "member"
          + username = "private-yusuke"
        }
      + members {
          + role     = "member"
          + username = "shou3008"
        }
      + members {
          + role     = "member"
          + username = "syuuya-nakatomi"
        }
      + members {
          + role     = "member"
          + username = "takato256"
        }
      + members {
          + role     = "member"
          + username = "tosuke"
        }
    }

Plan: 17 to add, 3 to change, 0 to destroy.

─────────────────────────────────────────────────────────────────────────────

Note: You didn't use the -out option to save this plan, so Terraform can't
guarantee to take exactly these actions if you run "terraform apply" now.

Copy link
Contributor

@Nishinoyama Nishinoyama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mu-ruU1 mu-ruU1 merged commit e75131f into master Jun 15, 2024
1 check passed
@mu-ruU1 mu-ruU1 deleted the ictsc2024 branch June 15, 2024 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants