Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vcpkg manifest mode configuration #116

Merged
merged 3 commits into from
Nov 14, 2024
Merged

Conversation

mfussi66
Copy link
Member

This PR adds the vcpkg configuration in manifest mode, so that creo2urdf can have its dependencies installed separately from the system-wide vcpkg packages.
In this way, the user can just run vcpkg install in the top level directory and it will have the dependencies installed inside it.

The command vcpkg install is ran every time the the CMake configure step is launched, and it will use the cached packages if they exist already.

Additionally, the triplet is set and not allowed as option since it's the only way to compile creo2urdf.

@mfussi66 mfussi66 self-assigned this Nov 14, 2024
CMakeLists.txt Outdated Show resolved Hide resolved
vcpkg.json Show resolved Hide resolved
@traversaro
Copy link
Member

Should we update the README to use the new manifest?

@traversaro
Copy link
Member

Anyhow, the comments are non-blocking on my side.

Copy link
Member

@Nicogene Nicogene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks @mfussi66 ! I will do a release of creo2urdf and then update the GAs in order to use this new machinery

@Nicogene Nicogene merged commit 9fee4ed into icub-tech-iit:master Nov 14, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants