Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚨 [security] Update probot 12.3.0 β†’ 13.2.1 (major) #137

Closed
wants to merge 1 commit into from

Conversation

depfu[bot]
Copy link
Contributor

@depfu depfu bot commented May 2, 2024


🚨 Your current dependencies have known security vulnerabilities 🚨

This dependency update fixes known security vulnerabilities. Please see the details below and assess their impact carefully. We recommend to merge and deploy this as soon as possible!


Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ probot (12.3.0 β†’ 13.2.1) Β· Repo

Security Advisories 🚨

🚨 Unauthenticated Denial of Service in the octokit/webhooks library

Impact

Versions v9.26.0, v10.9.x), v11.1.x, v12.0.x all contained the code that would throw the error.

Specifically, during a pentest we encountered a bug in the octokit/webhooks library (a dependency of Probot, a framework for building Github Apps). The resulting request was found to cause an uncaught exception that ends the nodejs process.

The problem is caused by an issue with error handling in the @octokit/webhooks library because the error can be undefined in some cases.

Credit goes to @pb82 (for the early analysis) and @rh-tguittet (for discovery).

Patches

Maintenance releases for the Error being thrown by the verify method in octokit/webhooks.js

Maintenance release for the reference for octokit/webhooks.js in app.js

Maintenance release for the reference for octokit/webhooks.js in octokit.js

Maintenance release for the reference for octokit/webhooks.js in Protobot

Workarounds

It is recommend that all users upgrade to the latest version of octokit/webhooks.js or use one of the updated back ported versions.

Release Notes

13.2.1

13.2.1 (2024-05-01)

Bug Fixes

13.2.0

13.2.0 (2024-04-03)

Features

13.1.2

13.1.2 (2024-03-26)

Bug Fixes

  • deps: update dependency express to v4.19.2 [security] (b1d3ac3)

13.1.0

13.1.0 (2024-03-12)

Features

13.0.2

13.0.2 (2024-02-03)

Bug Fixes

  • deps: update dependency commander to v12 (737835f)

13.0.1

13.0.1 (2024-01-26)

Bug Fixes

13.0.0

13.0.0 (2024-01-25)

Features

BREAKING CHANGES

  • Drop support for NodeJS < 18
  • replaceΒ node-fetchΒ with the Fetch API
  • default webhookPath is nowΒ /api/github/webhooks
  • probot receiveΒ now only supports payloads in JSON format, previously also (unintionally) allowed JS.

12.3.3

12.3.3 (2023-11-15)

Bug Fixes

12.3.2

12.3.2 (2023-11-14)

Bug Fixes

12.3.1

12.3.1 (2023-06-14)

Bug Fixes

  • typescript: simplify ProbotWebhooks object (#1833) (7b09369)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 45 commits:


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu cancel merge
Cancels automatic merging of this PR
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

Copy link

vercel bot commented May 2, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
issue-to-branch ❌ Failed (Inspect) May 2, 2024 11:26am

@depfu depfu bot added dependencies Pull requests that update a dependency file depfu labels May 2, 2024
Copy link
Contributor Author

depfu bot commented May 8, 2024

Closed in favor of #138.

@depfu depfu bot closed this May 8, 2024
Copy link
Contributor Author

depfu bot commented May 8, 2024

Closed in favor of #138.

@depfu depfu bot deleted the depfu/update/yarn/probot-13.2.1 branch May 8, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file depfu
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants