Make TMAP8 optional #69
Conversation
|
Job Documentation on e9de1d8 wanted to post the following: View the site here This comment will be updated on new commits. |
cticenhour
force-pushed
the
optional-tmap8
branch
from
c96063a
to
8a5dcc6
Compare
Refs idaholab#52 This aligns with the status of Cardinal, which was also made optional in idaholab#53
cticenhour
force-pushed
the
optional-tmap8
branch
from
8a5dcc6
to
e9de1d8
Compare
There was a problem hiding this comment.
Looks great to me! I like how you consolidated TMAP8 and Cardinal in how they are called. Thank you @cticenhour!
Is there anything needed (new recipes?) before merging this?
|
@simopier Just need to remove TMAP8 from the "no optional" recipe (this will be done in idaholab/civet_recipes#1879). Then we can refresh the test on this PR and merge in if all is well. I will get this in during the coming work week. |
|
Job Test no optional on e9de1d8 : invalidated by @cticenhour Refresh no optional test due to recipe update that removes TMAP8. |
|
Revised "no optional" test passing without TMAP8 submodule available: https://civet.inl.gov/job/2418622/. |
Refs #52
This aligns with the status of Cardinal, which was also made optional in #53.