Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MooseMesh::buildLowerDMesh needs to add separate blocks for lower-d elements in different types #29142

Closed
YaqiWang opened this issue Nov 26, 2024 · 0 comments · Fixed by #29144
Labels
T: task An enhancement to the software.

Comments

@YaqiWang
Copy link
Contributor

Motivation

This is an issue often encountered in 3D meshes. Currently, the function adds two lower-d blocks, one for all interior sides and another for all boundary sides. In 3D, the sides could be in different element types, like either triangle, quad. This will cause an issue when writing the mesh into an Exodus mesh, where a mesh block must have the same element type.

Design

Even though calculations does not care lower-d element types, it could be a good idea to separate the mesh block into blocks based on the element types. We will need to add getters in MooseMesh to get a vector of interior side blocks and boundary side blocks, so that applications do not use Moose::INTERNAL_SIDE_LOWERD_ID or INTERNAL_SIDE_LOWERD_SUBDOMAIN directly. We need to add a test that contains elements like prism which have sides in different types.

Impact

Make calculations with lower-d mesh blocks able to perform Exodus outputs.

@YaqiWang YaqiWang added the T: task An enhancement to the software. label Nov 26, 2024
YaqiWang added a commit to YaqiWang/moose that referenced this issue Nov 26, 2024
YaqiWang added a commit to YaqiWang/moose that referenced this issue Nov 26, 2024
YaqiWang added a commit to YaqiWang/moose that referenced this issue Nov 26, 2024
YaqiWang added a commit to YaqiWang/moose that referenced this issue Nov 26, 2024
YaqiWang added a commit to YaqiWang/moose that referenced this issue Nov 26, 2024
YaqiWang added a commit to YaqiWang/moose that referenced this issue Nov 26, 2024
YaqiWang added a commit to YaqiWang/moose that referenced this issue Nov 26, 2024
YaqiWang added a commit to YaqiWang/moose that referenced this issue Nov 26, 2024
YaqiWang added a commit to YaqiWang/moose that referenced this issue Nov 27, 2024
YaqiWang added a commit to YaqiWang/moose that referenced this issue Nov 27, 2024
YaqiWang added a commit to YaqiWang/moose that referenced this issue Nov 27, 2024
YaqiWang added a commit to YaqiWang/moose that referenced this issue Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T: task An enhancement to the software.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant