Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

All props in stateful storage should be non-AD #16845

Merged
merged 2 commits into from
Feb 2, 2021
Merged

All props in stateful storage should be non-AD #16845

merged 2 commits into from
Feb 2, 2021

Conversation

lindsayad
Copy link
Member

Otherwise we will multiply our memory usage by 51x which isn't ideal.

Closes #16836

@hugary1995
Copy link
Contributor

I'll re-do some of the profiling in #16466 when this gets merged. The profiling data told me the bottleneck of the AD performance there was related to memory allocation.

@lindsayad lindsayad force-pushed the stateful-ad-mat-16836 branch from fab0981 to 7f615ee Compare February 1, 2021 23:09
@lindsayad
Copy link
Member Author

Copying from #16773:

Before this PR, with a finite strain input from @makeclean, I had this graph:
fixed-temp
which was taken from the middle of initing stateful props, and shortly before I canceled the simulation so my computer wouldn't run out of memory to this graph:
post-stateful-fixes
which was taken after initing stateful properties...because now we can get to that point without running out of memory. So 84 GB for stateful properties (and that number was still growing) to 4GB. I'm a big fan. Thanks for your helpful inputs @makeclean. Good news @dschwen @recuero !

@dschwen
Copy link
Member

dschwen commented Feb 2, 2021

Nice!

Otherwise we will multiply our memory usage by 51x which isn't ideal

Or a lot more. We're already running Bison with AD vector sizes > 100 for 2nd order elements in 3D...

@moosebuild
Copy link
Contributor

moosebuild commented Feb 2, 2021 •
edited
Loading

Job Documentation on 5d4e49a wanted to post the following:

View the site here

This comment will be updated on new commits.

@lindsayad
All props in stateful storage should be non-AD
a2eea10 
Otherwise we will multiply our memory usage by 51x which isn't ideal.

Closes idaholab#16836
@lindsayad lindsayad force-pushed the stateful-ad-mat-16836 branch from 7f615ee to a2eea10 Compare February 2, 2021 01:46
@lindsayad
Remove now extraneous shift code
5d4e49a 
The properties in `MaterialPropertyStorage` are all regular
`MaterialProperty` so there is no need to change property types when
shifting anymore.

Refs idaholab#16836
@lindsayad lindsayad force-pushed the stateful-ad-mat-16836 branch from 74be21e to 5d4e49a Compare February 2, 2021 17:17
@lindsayad lindsayad requested review from fdkong and dschwen February 2, 2021 18:27
@fdkong fdkong merged commit f4d8ef0 into idaholab:next Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fdkong fdkong fdkong approved these changes

@dschwen dschwen Awaiting requested review from dschwen

Assignees
No one assigned
Labels
PR: Ready for review/merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Eliminate tremendous memory requirements of AD "stateful" material properties
5 participants
@lindsayad @hugary1995 @dschwen @moosebuild @fdkong