Add RGMB option to enable flexible assembly stitching

[shikhar413]

Reason

Design

Impact

refs #28230

[miaoyinb]

I only reviewed FlexiblePattern part. May take a look at other parts later today. Thanks

[moosebuild]

Job Documentation on 3e3e0c9 wanted to post the following:

View the site here

This comment will be updated on new commits.

[miaoyinb]

Just some minor comments. Thanks.

[shikhar413]

@GiudGiud @miaoyinb all comments should be addressed now, will push another commit to address remaining test failure in a bit

[miaoyinb]

Some final minor suggestions. Thanks.

[moosebuild]

Job Coverage on 3e3e0c9 wanted to post the following:

Framework coverage

Coverage did not change

Modules coverage

Reactor

	468ab7	#28231 3e3e0c
	Total	Total	+/-	New
Rate	93.70%	93.61%	-0.09%	91.28%
Hits	7304	7430	+126	199
Misses	491	507	+16	19

Diff coverage report

Full coverage report

Full coverage reports

Reports

• framework
• chemical_reactions
• combined
• contact
• electromagnetics
• external_petsc_solver
• fluid_properties
• fsi
• functional_expansion_tools
• geochemistry
• heat_transfer
• level_set
• misc
• navier_stokes
• optimization
• peridynamics
• phase_field
• porous_flow
• ray_tracing
• rdg
• reactor
• richards
• scalar_transport
• solid_mechanics
• solid_properties
• stochastic_tools
• thermal_hydraulics
• xfem

This comment will be updated on new commits.

[GiudGiud]

I'll review this when I get back unless someone else does it first
@miaoyinb thank you for reviewing!

[moosebuild]

Job Precheck on 6122d1d wanted to post the following:

Your code requires style changes.

A patch was auto generated and copied here
You can directly apply the patch by running, in the top level of your repository:

curl -s https://mooseframework.inl.gov/docs/PRs/28231/clang_format/style.patch | git apply -v

Alternatively, with your repository up to date and in the top level of your repository:

git clang-format 468ab73aa23733be91b7e142dd2926aeb230ff53

[GiudGiud]

Thanks for the PR @shikhar413 . I think this solves a big potential problem for a wide range of users, and thank you for reviewing @miaoyinb

[milljm]

@shikhar413, this merge seems to be breaking Macintosh Intel targets only. Ref: https://civet.inl.gov/job/2367026/.

[1.392s]     FAIL reactor/test:meshgenerators/core_mesh_generator.flexible_stitching_hex FAILED (ERRMSG) [reactor-opt]

Error:

reactor/test:meshgenerators/core_mesh_generator.flexible_stitching_hex: 
reactor/test:meshgenerators/core_mesh_generator.flexible_stitching_hex: *** ERROR ***
reactor/test:meshgenerators/core_mesh_generator.flexible_stitching_hex: Found point (x,y,z)=( 2.04665, 1.11022e-16,        0) on hole boundary but outside outer boundary
reactor/test:meshgenerators/core_mesh_generator.flexible_stitching_hex: Stack frames: 15
reactor/test:meshgenerators/core_mesh_generator.flexible_stitching_hex: 0: 0   libmesh_opt.0.dylib                 0x000000011145dc1e libMesh::print_trace(std::__1::basic_ostream<char, std::__1::char_traits<char>>&) + 1070
reactor/test:meshgenerators/core_mesh_generator.flexible_stitching_hex: 1: 1   libmesh_opt.0.dylib                 0x000000011145b8b3 libMesh::MacroFunctions::report_error(char const*, int, char const*, char const*, std::__1::basic_ostream<char, std::__1::char_traits<char>>&) + 179
reactor/test:meshgenerators/core_mesh_generator.flexible_stitching_hex: 2: 2   libmesh_opt.0.dylib                 0x0000000111a0145b libMesh::TriangulatorInterface::verify_holes(libMesh::TriangulatorInterface::Hole const&) + 731
reactor/test:meshgenerators/core_mesh_generator.flexible_stitching_hex: 3: 3   libmesh_opt.0.dylib                 0x0000000111a00a19 libMesh::TriangulatorInterface::elems_to_segments() + 4969
reactor/test:meshgenerators/core_mesh_generator.flexible_stitching_hex: 4: 4   libmesh_opt.0.dylib                 0x00000001119e9bcb libMesh::Poly2TriTriangulator::triangulate() + 91
reactor/test:meshgenerators/core_mesh_generator.flexible_stitching_hex: 5: 5   libmoose-opt.0.dylib                0x000000010f413bde XYDelaunayGenerator::generate() + 2990
reactor/test:meshgenerators/core_mesh_generator.flexible_stitching_hex: 6: 6   libmoose-opt.0.dylib                0x000000010f4b1c80 MeshGenerator::generateInternal() + 160
reactor/test:meshgenerators/core_mesh_generator.flexible_stitching_hex: 7: 7   libmoose-opt.0.dylib                0x00000001102407a5 MeshGeneratorSystem::executeMeshGenerators() + 1509
reactor/test:meshgenerators/core_mesh_generator.flexible_stitching_hex: 8: 8   libmoose-opt.0.dylib                0x000000010fe52335 ActionWarehouse::executeActionsWithAction(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>> const&) + 1381
reactor/test:meshgenerators/core_mesh_generator.flexible_stitching_hex: 9: 9   libmoose-opt.0.dylib                0x000000010fe51bd8 ActionWarehouse::executeAllActions() + 280
reactor/test:meshgenerators/core_mesh_generator.flexible_stitching_hex: 10: 10  libmoose-opt.0.dylib                0x00000001101d81ff MooseApp::runInputFile() + 143
reactor/test:meshgenerators/core_mesh_generator.flexible_stitching_hex: 11: 11  libmoose-opt.0.dylib                0x00000001101d4542 MooseApp::run() + 1250
reactor/test:meshgenerators/core_mesh_generator.flexible_stitching_hex: 12: 12  reactor-opt                         0x000000010c6bdc45 void Moose::main<ReactorTestApp>(int, char**) + 133
reactor/test:meshgenerators/core_mesh_generator.flexible_stitching_hex: 13: 13  reactor-opt                         0x000000010c6bdbb9 main + 9
reactor/test:meshgenerators/core_mesh_generator.flexible_stitching_hex: 14: 14  dyld                                0x00007ff8059cb366 start + 1942
reactor/test:meshgenerators/core_mesh_generator.flexible_stitching_hex: [0] ../src/mesh/triangulator_interface.C, line 449, compiled Jul 30 2024 at 17:46:23
reactor/test:meshgenerators/core_mesh_generator.flexible_stitching_hex: 
reactor/test:meshgenerators/core_mesh_generator.flexible_stitching_hex: 
reactor/test:meshgenerators/core_mesh_generator.flexible_stitching_hex: Stack frames: 7
reactor/test:meshgenerators/core_mesh_generator.flexible_stitching_hex: 0: 0   libmesh_opt.0.dylib                 0x000000011145dc1e libMesh::print_trace(std::__1::basic_ostream<char, std::__1::char_traits<char>>&) + 1070
reactor/test:meshgenerators/core_mesh_generator.flexible_stitching_hex: 1: 1   libmoose-opt.0.dylib                0x00000001101de321 moose::internal::mooseErrorRaw(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>) + 769
reactor/test:meshgenerators/core_mesh_generator.flexible_stitching_hex: 2: 2   libmoose-opt.0.dylib                0x000000010fa5f0e1 void mooseError<char const*>(char const*&&) + 273
reactor/test:meshgenerators/core_mesh_generator.flexible_stitching_hex: 3: 3   libmoose-opt.0.dylib                0x00000001101d4ab3 MooseApp::run() + 2643
reactor/test:meshgenerators/core_mesh_generator.flexible_stitching_hex: 4: 4   reactor-opt                         0x000000010c6bdc45 void Moose::main<ReactorTestApp>(int, char**) + 133
reactor/test:meshgenerators/core_mesh_generator.flexible_stitching_hex: 5: 5   reactor-opt                         0x000000010c6bdbb9 main + 9
reactor/test:meshgenerators/core_mesh_generator.flexible_stitching_hex: 6: 6   dyld                                0x00007ff8059cb366 start + 1942
reactor/test:meshgenerators/core_mesh_generator.flexible_stitching_hex: Abort(1) on node 0 (rank 0 in comm 0): application called MPI_Abort(MPI_COMM_WORLD, 1) - process 0
reactor/test:meshgenerators/core_mesh_generator.flexible_stitching_hex: 
reactor/test:meshgenerators/core_mesh_generator.flexible_stitching_hex: ################################################################################
reactor/test:meshgenerators/core_mesh_generator.flexible_stitching_hex: Tester failed, reason: ERRMSG

Any ideas? Can we fix this or perhaps do we need to skip this test, when it encounters Mac Intel?

[shikhar413]

Hmm I'm not sure. This is most likely an issue with XYDelaunayTriangulator but I don't really have a way to reproduce this error since I don't have a Intel Mac environment.

Any ideas on this @GiudGiud @miaoyinb?

[miaoyinb]

Hmm I'm not sure. This is most likely an issue with XYDelaunayTriangulator but I don't really have a way to reproduce this error since I don't have a Intel Mac environment.

Any ideas on this @GiudGiud @miaoyinb?

I think it might be due to "verify_holes=true" in FlexiblePatternGenerator. If so, it's a known issue libMesh/libmesh#3496. You can set that param as false to skip this check to avert this "false positive"

[shikhar413]

Thanks @miaoyinb let me put in a patch for this