Updating Limiters for Finite Volume Formulation #28892

tanoret · 2024-10-19T00:50:44Z

Closes #28891

tanoret · 2024-10-19T00:51:05Z

@freiler plase also take a look if you can

tanoret · 2024-10-19T00:58:50Z

This are the current results on October 18, 2024

Upwind

Variartion Limited Second-Order Upwind:

Min-Mod:

VanLeer:

QUICK:

Venkatakrishnan:

Notes:

Flux limiters are lagged in time step
Deterioration in convergence is only observed for Venkatakrishnan (all the rest converge as upwind)
QUICK does not show improvements with respect to upwind

tanoret · 2024-10-19T01:01:11Z

To-do:

Modify the implicit vs explicit update in the limiters and select the best default option for each
Correct QUICK issues
Improve the documentation for all functions in limiters and MathFVUtils
Write updated documentation on limiters
Test limited advection schemes from two fronts

GiudGiud · 2024-10-19T09:56:33Z

you'll want to get rid of the submodule update in the wasp folder

lindsayad

Should I wait to review this until you've removed the WIP label? In which case should we convert this to draft?

framework/include/base/MooseFunctorArguments.h

tanoret · 2024-10-24T22:45:32Z

This are the latest results. Images are in the docs. Limiters are working as expected. Tests include:

advection in a cartesian mesh in two directions (bottom-left to top-right and inverted)
advection in a triangular mesh
lid-driven cavity with Newton
lid-driven cavity with SIMPLE

large_media

framework/include/limiters/Limiter.h

lindsayad · 2024-10-24T22:53:12Z

You can mention me once you're done pushing and I will review. Going to unsubscribe for now

large_media

GiudGiud · 2024-10-28T15:21:11Z

We'll want to reduce the size of the tests. 25x25 for a full grid of tests is bloating the repo. You ll see it fail the same way with 5x5 but at (theoretically) 1/25th of the memory cost

moosebuild · 2024-10-28T16:01:25Z

Job Documentation, step Docs: sync website on fe27fcd wanted to post the following:

View the site here

This comment will be updated on new commits.

framework/include/base/MooseFunctorArguments.h

GiudGiud

early feedback, not quite done but might be delayed tomorrow

framework/include/variables/MooseVariableFV.h

modules/navier_stokes/src/fvkernels/INSFVAdvectionKernel.C

modules/navier_stokes/src/fvkernels/INSFVEnergyAdvection.C

modules/navier_stokes/test/tests/finite_volume/limiters/dispersion-test/tests

framework/include/limiters/Limiter.h

framework/include/limiters/MinModLimiter.h

large_media

tanoret · 2024-10-29T14:20:50Z

For the fvkernels/mms/advective-outflow.QUICKLimiter, which is supposed to test QUICK convergence with order $2 \pm 0.05$, we are converging with order 2.3. Does someone know rapidly what could be going on with this test or should I dig deeper into this?

large_media

…lab#28891

… vanLeer vector limiter (ref difs ~1e-5) Refs idaholab#28891

…nvergence is at leaste the required order of convergence Refs idaholab#28891

…ionKernel Refs idaholab#28891

…ab#28891

…ng test tolerance Refs idaholab#28891

grmnptr

Looks good to me, thanks for addressing all the comments on this PR! @GiudGiud if this is good to go from your side too we could merge this.

framework/include/limiters/SOULimiter.h

GiudGiud

actually this last commit should be squashed in a previous one
see
dc52825
15691c9

you re checking in 8 gold files twice

tanoret · 2024-12-01T19:34:47Z

actually this last commit should be squashed in a previous one see dc52825 15691c9

you re checking in 8 gold files twice

I will delete the gold files from 15691c9 Finding a issues with squashing and don't have time to evaluate non-regression in the flow test bed

Edit: Should be good

Co-authored-by: Guillaume Giudicelli <guillaume.giudicelli@gmail.com> regolding tests to latest mods in limiters and avoid testing unnecessary recovers Refs idaholab#28891

…lab#28891

Co-authored-by: Peter German <31662443+grmnptr@users.noreply.github.com>

…efs idaholab#28891

…der limiting schemes Refs idaholab#28891

large_media

…b#28891

GiudGiud

test failures (FENIX build failure) due to old recipes (pyne issue) and unrelated

tanoret requested review from lindsayad, GiudGiud, grmnptr and roystgnr as code owners October 19, 2024 00:50

tanoret force-pushed the lagging_rc branch from 5e841f3 to b3ebc22 Compare October 20, 2024 17:34

lindsayad reviewed Oct 24, 2024

View reviewed changes

framework/include/base/MooseFunctorArguments.h Show resolved Hide resolved

tanoret changed the title ~~[WIP] Updating Limiters for Finite Volume Formulation~~ Updating Limiters for Finite Volume Formulation Oct 24, 2024

moosebuild reviewed Oct 24, 2024

View reviewed changes

large_media Outdated Show resolved Hide resolved

tanoret requested a review from permcody as a code owner October 24, 2024 22:51

lindsayad reviewed Oct 24, 2024

View reviewed changes

framework/include/limiters/Limiter.h Outdated Show resolved Hide resolved

tanoret force-pushed the lagging_rc branch from 375351d to 49dd7f5 Compare October 26, 2024 01:24

moosebuild reviewed Oct 26, 2024

View reviewed changes

large_media Outdated Show resolved Hide resolved

tanoret force-pushed the lagging_rc branch from 49dd7f5 to f5e60f7 Compare October 28, 2024 13:24

moosebuild reviewed Oct 28, 2024

View reviewed changes

large_media Outdated Show resolved Hide resolved

tanoret force-pushed the lagging_rc branch from f5e60f7 to 149d840 Compare October 28, 2024 13:37

moosebuild reviewed Oct 28, 2024

View reviewed changes

large_media Outdated Show resolved Hide resolved

GiudGiud reviewed Oct 28, 2024

View reviewed changes

framework/include/base/MooseFunctorArguments.h Show resolved Hide resolved

GiudGiud reviewed Oct 29, 2024

View reviewed changes

moosebuild reviewed Oct 29, 2024

View reviewed changes

large_media Outdated Show resolved Hide resolved

moosebuild reviewed Oct 29, 2024

View reviewed changes

large_media Outdated Show resolved Hide resolved

tanoret force-pushed the lagging_rc branch from 1bc9eb5 to 83e44c5 Compare October 29, 2024 15:28

tanoret added 6 commits November 27, 2024 15:40

style changes required by code pre-check and removing wasp Refs idaho…

7c4a199

…lab#28891

chaging interpolation method for vectors in MathFVUtils and regolding…

1f98ca3

… vanLeer vector limiter (ref difs ~1e-5) Refs idaholab#28891

changing fvkernels/mms/advection-outflow test logic to ensure that co…

0eed9d7

…nvergence is at leaste the required order of convergence Refs idaholab#28891

extending supported two-term-boundary expansion methods in INSFAdvect…

4a285fd

…ionKernel Refs idaholab#28891

completing argument definition for passing compile checks Refs idahol…

3a8de79

…ab#28891

completing argument definition for passing compile checks and modifyi…

4c26912

…ng test tolerance Refs idaholab#28891

tanoret force-pushed the lagging_rc branch 2 times, most recently from c580b5b to 5459bb6 Compare November 27, 2024 23:27

grmnptr approved these changes Dec 1, 2024

View reviewed changes

GiudGiud reviewed Dec 1, 2024

View reviewed changes

framework/include/limiters/SOULimiter.h Show resolved Hide resolved

GiudGiud requested changes Dec 1, 2024

View reviewed changes

tanoret and others added 9 commits December 1, 2024 12:40

Apply suggestions from giudgiud code review 1 Refs idaholab#28891

678cf6d

Co-authored-by: Guillaume Giudicelli <guillaume.giudicelli@gmail.com> regolding tests to latest mods in limiters and avoid testing unnecessary recovers Refs idaholab#28891

addressing guiallaume's code-reviewer comments Refs idaholab#28891

3a28d09

changing test tolerances to match serial and parallel runs Refs idaho…

a05b07f

…lab#28891

Apply suggestions from code review peter Refs idaholab#28891

d199348

Co-authored-by: Peter German <31662443+grmnptr@users.noreply.github.com>

Disable recover due to comparison on final timestep Refs idaholab#28891

7c47d77

Transition towards less limiting of SOU and move tests to framework R…

8acd644

…efs idaholab#28891

Add error messages for steady state executioners when using second or…

af9d399

…der limiting schemes Refs idaholab#28891

regolding dispersion tests Refs idaholab#28891

e5a7a04

Modify linked design file in dispersion test.

f76a9b7

tanoret force-pushed the lagging_rc branch from dc52825 to 746f535 Compare December 1, 2024 19:41

moosebuild reviewed Dec 1, 2024

View reviewed changes

large_media Outdated Show resolved Hide resolved

tanoret force-pushed the lagging_rc branch from 746f535 to d5d744d Compare December 2, 2024 16:00

moosebuild reviewed Dec 2, 2024

View reviewed changes

large_media Outdated Show resolved Hide resolved

regolding for max_treads=1 in segreated lid-driven tests Refs idahola…

fe27fcd

…b#28891

tanoret force-pushed the lagging_rc branch from d5d744d to fe27fcd Compare December 2, 2024 16:28

GiudGiud approved these changes Dec 2, 2024

View reviewed changes

idaholab deleted a comment from moosebuild Dec 2, 2024

GiudGiud merged commit 4a6a925 into idaholab:next Dec 2, 2024
49 of 51 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updating Limiters for Finite Volume Formulation #28892

Updating Limiters for Finite Volume Formulation #28892

tanoret commented Oct 19, 2024

tanoret commented Oct 19, 2024

tanoret commented Oct 19, 2024 •

edited

Loading

tanoret commented Oct 19, 2024 •

edited

Loading

GiudGiud commented Oct 19, 2024

lindsayad left a comment

tanoret commented Oct 24, 2024

lindsayad commented Oct 24, 2024

GiudGiud commented Oct 28, 2024

moosebuild commented Oct 28, 2024 •

edited

Loading

GiudGiud left a comment

tanoret commented Oct 29, 2024 •

edited

Loading

grmnptr left a comment

GiudGiud left a comment •

edited

Loading

tanoret commented Dec 1, 2024 •

edited

Loading

GiudGiud left a comment

Updating Limiters for Finite Volume Formulation #28892

Updating Limiters for Finite Volume Formulation #28892

Conversation

tanoret commented Oct 19, 2024

tanoret commented Oct 19, 2024

tanoret commented Oct 19, 2024 • edited Loading

tanoret commented Oct 19, 2024 • edited Loading

GiudGiud commented Oct 19, 2024

lindsayad left a comment

Choose a reason for hiding this comment

tanoret commented Oct 24, 2024

lindsayad commented Oct 24, 2024

GiudGiud commented Oct 28, 2024

moosebuild commented Oct 28, 2024 • edited Loading

GiudGiud left a comment

Choose a reason for hiding this comment

tanoret commented Oct 29, 2024 • edited Loading

grmnptr left a comment

Choose a reason for hiding this comment

GiudGiud left a comment • edited Loading

Choose a reason for hiding this comment

tanoret commented Dec 1, 2024 • edited Loading

GiudGiud left a comment

Choose a reason for hiding this comment

tanoret commented Oct 19, 2024 •

edited

Loading

tanoret commented Oct 19, 2024 •

edited

Loading

moosebuild commented Oct 28, 2024 •

edited

Loading

tanoret commented Oct 29, 2024 •

edited

Loading

GiudGiud left a comment •

edited

Loading

tanoret commented Dec 1, 2024 •

edited

Loading