Linear FV Fluid Energy equation #28952

freiler · 2024-10-28T20:08:45Z

Closes #28951

framework/src/linearfvkernels/LinearFVSource.C

framework/include/linearfvkernels/LinearFVSource.h

modules/navier_stokes/include/linearfvkernels/LinearFVMomentumBoussinesq.h

modules/navier_stokes/src/executioners/SIMPLE.C

modules/navier_stokes/src/linearfvkernels/LinearFVEnergyAdvection.C

modules/navier_stokes/src/linearfvkernels/LinearFVMomentumBoussinesq.C

modules/navier_stokes/src/linearfvkernels/LinearFVEnergyAdvection.C

grmnptr

Very nice job! A few comments here and there.

modules/navier_stokes/doc/content/source/linearfvkernels/LinearFVEnergyAdvection.md

modules/navier_stokes/doc/content/source/linearfvkernels/LinearFVMomentumBoussinesq.md

modules/navier_stokes/doc/content/source/linearfvkernels/LinearFVEnergyAdvection.md

...tokes/test/tests/finite_volume/ins/natural_convection/diff_heated_cavity_linear_segregated.i

moosebuild · 2024-11-07T19:54:02Z

Job Documentation, step Docs: sync website on f67967a wanted to post the following:

View the site here

This comment will be updated on new commits.

…holab#28951)

…Boussinesq buoyancy force treatment idaholab#28951

moosebuild · 2024-11-08T23:03:04Z

Job Precheck, step Clang format on 993dd22 wanted to post the following:

Your code requires style changes.

A patch was auto generated and copied here
You can directly apply the patch by running, in the top level of your repository:

curl -s https://mooseframework.inl.gov/docs/PRs/28952/clang_format/style.patch | git apply -v

Alternatively, with your repository up to date and in the top level of your repository:

git clang-format d3e2afe6dfd70bc0c565cc1f48d6eb85bc94c0f0

modules/navier_stokes/test/tests/finite_volume/ins/natural_convection/tests

Co-authored-by: Peter German <31662443+grmnptr@users.noreply.github.com> Apply suggestions from code review Co-authored-by: Peter German <31662443+grmnptr@users.noreply.github.com>

moosebuild · 2024-11-11T21:09:39Z

Job Precheck on e1fa29f : invalidated by @grmnptr

moosebuild · 2024-11-11T22:30:22Z

Job Non unity build on e1fa29f : invalidated by @grmnptr

framework/doc/content/source/linearfvkernels/LinearFVEnergyAdvection.md

moosebuild · 2024-11-12T18:41:54Z

Job Precheck on d0c0445 : invalidated by @grmnptr

grmnptr

This test is failing locally with more than 2 cores. This should fix it.

modules/navier_stokes/test/tests/finite_volume/ins/channel-flow/linear-segregated/2d/tests

moosebuild · 2024-11-13T01:06:52Z

Job Conda (Ubuntu) on b91e2ff : invalidated by @grmnptr

grmnptr

Nice!

modules/navier_stokes/src/linearfvkernels/LinearFVEnergyAdvection.C

modules/navier_stokes/src/linearfvkernels/LinearFVMomentumBoussinesq.C

grmnptr

It fails because it thinks it needs to test threading.

...les/navier_stokes/test/tests/finite_volume/ins/natural_convection/linear_segregated/2d/tests

modules/navier_stokes/test/tests/finite_volume/ins/natural_convection/tests

moosebuild · 2024-11-14T02:11:08Z

Job Coverage, step Generate coverage on f67967a wanted to post the following:

Framework coverage

	737741	#28952 f67967
	Total	Total	+/-	New
Rate	85.11%	85.11%	+0.00%	100.00%
Hits	106985	106988	+3	4
Misses	18718	18717	-1	0

Diff coverage report

Full coverage report

Modules coverage

Navier stokes

	737741	#28952 f67967
	Total	Total	+/-	New
Rate	84.64%	84.68%	+0.04%	91.67%
Hits	17081	17182	+101	110
Misses	3100	3108	+8	10

Diff coverage report

Full coverage report

Full coverage reports

Reports

This comment will be updated on new commits.

moosebuild · 2024-11-14T16:20:27Z

Job Conda (Ubuntu) on f67967a : invalidated by @grmnptr

GiudGiud · 2024-11-14T18:18:29Z

I added the parallel sweeps while we wait for next to be open for merges

grmnptr · 2024-11-14T18:42:27Z

Great idea!

GiudGiud · 2024-11-14T19:16:08Z

I think I picked the wrong ones for this PR. I ll try again, bear with me. Sweep NS will fail due to other tests already but we can look at the related tests

moosebuild · 2024-11-14T20:49:55Z

Job Sweep navier_stokes (incomplete) on f67967a : canceled by @grmnptr

GiudGiud · 2024-11-15T01:23:05Z

Glad to see linear FV get another contributor! Let's do it

freiler requested review from lindsayad, GiudGiud and grmnptr as code owners October 28, 2024 20:08

GiudGiud reviewed Oct 29, 2024

View reviewed changes

GiudGiud self-assigned this Oct 30, 2024

GiudGiud reviewed Nov 7, 2024

View reviewed changes

modules/navier_stokes/src/linearfvkernels/LinearFVEnergyAdvection.C Show resolved Hide resolved

grmnptr requested changes Nov 7, 2024

View reviewed changes

freiler and others added 10 commits November 8, 2024 13:52

Adding unchecked/unfinished LinearFV kernels for Boussinesq NC

6ee628f

Compileable kernels for Boussinesq and Energy advection, first iteration

4810035

Added scaling option to LinearFVSource term

84e92c8

Add energy solver to Linear Simple

e6301e2

Modify advection kernel. (idaholab#28951)

24cb5cc

Modify boussinesq kernel to respect pseudo hydrostatic pressure. (ida…

723a3e8

…holab#28951)

Add execute command to SIMPLE at NONLINEAR. (idaholab#28951)

ab8d4d3

Add channel test case with Boussinesq. (idaholab#28951)

2aad0c1

Modify EnergyAdvection to solve for temperature

186e837

Multiply the Boussinesq force by the element volume

7d0399f

freiler force-pushed the linearFV-add-ons branch from 85cfe42 to 93081c3 Compare November 8, 2024 20:57

freiler added 3 commits November 8, 2024 15:53

Adding tests for the Boussinesq buoyancy treatment idaholab#28951

d86750b

Add documentation for the Linear FV Kernels for energy advection and …

962666a

…Boussinesq buoyancy force treatment idaholab#28951

Fix Documentation location idaholab#28951

fef2038

freiler force-pushed the linearFV-add-ons branch from 9e123e8 to 993dd22 Compare November 8, 2024 22:58

freiler force-pushed the linearFV-add-ons branch 3 times, most recently from 026bc39 to 3771569 Compare November 8, 2024 23:59

grmnptr requested changes Nov 11, 2024

View reviewed changes

modules/navier_stokes/test/tests/finite_volume/ins/natural_convection/tests Outdated Show resolved Hide resolved

Apply suggestions from code review

597925a

Co-authored-by: Peter German <31662443+grmnptr@users.noreply.github.com> Apply suggestions from code review Co-authored-by: Peter German <31662443+grmnptr@users.noreply.github.com>

freiler force-pushed the linearFV-add-ons branch from 3771569 to e1fa29f Compare November 11, 2024 21:02

grmnptr requested changes Nov 11, 2024

View reviewed changes

framework/doc/content/source/linearfvkernels/LinearFVEnergyAdvection.md Outdated Show resolved Hide resolved

freiler force-pushed the linearFV-add-ons branch 2 times, most recently from 247b20c to d0c0445 Compare November 12, 2024 16:34

grmnptr requested changes Nov 12, 2024

View reviewed changes

modules/navier_stokes/test/tests/finite_volume/ins/channel-flow/linear-segregated/2d/tests Show resolved Hide resolved

freiler force-pushed the linearFV-add-ons branch from d0c0445 to b91e2ff Compare November 13, 2024 00:25

grmnptr approved these changes Nov 13, 2024

View reviewed changes

GiudGiud reviewed Nov 13, 2024

View reviewed changes

modules/navier_stokes/src/linearfvkernels/LinearFVEnergyAdvection.C Outdated Show resolved Hide resolved

GiudGiud reviewed Nov 13, 2024

View reviewed changes

modules/navier_stokes/src/linearfvkernels/LinearFVMomentumBoussinesq.C Outdated Show resolved Hide resolved

GiudGiud approved these changes Nov 13, 2024

View reviewed changes

Address Peter's reviews- tests and doc idaholab#28951

c87f4f0

freiler force-pushed the linearFV-add-ons branch from b91e2ff to c87f4f0 Compare November 13, 2024 18:50

grmnptr requested changes Nov 13, 2024

View reviewed changes

...les/navier_stokes/test/tests/finite_volume/ins/natural_convection/linear_segregated/2d/tests Show resolved Hide resolved

modules/navier_stokes/test/tests/finite_volume/ins/natural_convection/tests Outdated Show resolved Hide resolved

Max threads=1 for linearFV variables in tests.

f67967a

moosebuild added the PR: Failed but allowed label Nov 14, 2024

grmnptr approved these changes Nov 14, 2024

View reviewed changes

moosebuild removed the PR: Failed but allowed label Nov 14, 2024

GiudGiud merged commit 37b999b into idaholab:next Nov 15, 2024
55 of 56 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Linear FV Fluid Energy equation #28952

Linear FV Fluid Energy equation #28952

freiler commented Oct 28, 2024

grmnptr left a comment

moosebuild commented Nov 7, 2024 •

edited

Loading

moosebuild commented Nov 8, 2024

moosebuild commented Nov 11, 2024

moosebuild commented Nov 11, 2024

moosebuild commented Nov 12, 2024

grmnptr left a comment

moosebuild commented Nov 13, 2024

grmnptr left a comment

grmnptr left a comment

moosebuild commented Nov 14, 2024

moosebuild commented Nov 14, 2024

GiudGiud commented Nov 14, 2024

grmnptr commented Nov 14, 2024

GiudGiud commented Nov 14, 2024

moosebuild commented Nov 14, 2024

GiudGiud commented Nov 15, 2024

Linear FV Fluid Energy equation #28952

Linear FV Fluid Energy equation #28952

Conversation

freiler commented Oct 28, 2024

grmnptr left a comment

Choose a reason for hiding this comment

moosebuild commented Nov 7, 2024 • edited Loading

moosebuild commented Nov 8, 2024

moosebuild commented Nov 11, 2024

moosebuild commented Nov 11, 2024

moosebuild commented Nov 12, 2024

grmnptr left a comment

Choose a reason for hiding this comment

moosebuild commented Nov 13, 2024

grmnptr left a comment

Choose a reason for hiding this comment

grmnptr left a comment

Choose a reason for hiding this comment

moosebuild commented Nov 14, 2024

Framework coverage

Modules coverage

Navier stokes

Full coverage reports

moosebuild commented Nov 14, 2024

GiudGiud commented Nov 14, 2024

grmnptr commented Nov 14, 2024

GiudGiud commented Nov 14, 2024

moosebuild commented Nov 14, 2024

GiudGiud commented Nov 15, 2024

moosebuild commented Nov 7, 2024 •

edited

Loading