-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move GapPerfectConductance from BISON to MOOSE #28982
Conversation
@Naktakala FYI |
Job Documentation, step Docs: sync website on 0e9f3d9 wanted to post the following: View the site here This comment will be updated on new commits. |
Job Coverage, step Generate coverage on 0e9f3d9 wanted to post the following: Framework coverageCoverage did not change Modules coverageHeat transfer
Full coverage reportsReports
This comment will be updated on new commits. |
81b1e02
to
26b6e2f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for moving this upstream @gambka !
modules/heat_transfer/test/tests/gap_perfect_transfer/gap_perfect_transfer.i
Outdated
Show resolved
Hide resolved
modules/heat_transfer/test/tests/gap_perfect_transfer/gap_perfect_transfer_rz.i
Outdated
Show resolved
Hide resolved
modules/heat_transfer/test/tests/gap_perfect_transfer/gap_perfect_transfer_rz.i
Outdated
Show resolved
Hide resolved
26b6e2f
to
f075647
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my comments have been addressed
f075647
to
41febb3
Compare
41febb3
to
0e9f3d9
Compare
renamed a file to avoid a doco failure |
I have a BISON patch ready and just needs to be merged that should avoid doco failures and not need any renames. |
feel free to revert if you want |
otherwise it's fine as it is |
The BISON change was merged into devel which should fix the failure on multiple files registering |
The necessary patch to BISON has made its way into master. I think the HPC failure will be unable to overcome until Sawtooth returns to service. |
Job Test HPC on 0e9f3d9 : invalidated by @lindsayad |
This looks like migrating technical debt from Bison to MOOSE. In the long term I'd rather fix our Contact action system to allow the use of mortar based thermal contact without mechanical contact. |
I agree with your long term goal. We also need to enable mortar contact to work on 1D simulations like the test included here that has node to node contact. What would be the reduced order mesh be used for mortar in these cases? |
Closes #28963.
I have a patch for BISON. Once approved I can merge the BISON change to remove these files so there is no conflict. No submodule update in BISON required.