Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move GapPerfectConductance from BISON to MOOSE #28982

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

gambka
Copy link
Contributor

@gambka gambka commented Oct 31, 2024

Closes #28963.

I have a patch for BISON. Once approved I can merge the BISON change to remove these files so there is no conflict. No submodule update in BISON required.

@gambka gambka requested a review from lindsayad as a code owner October 31, 2024 18:02
@gambka
Copy link
Contributor Author

gambka commented Oct 31, 2024

@Naktakala FYI

@moosebuild
Copy link
Contributor

moosebuild commented Oct 31, 2024

Job Documentation, step Docs: sync website on 0e9f3d9 wanted to post the following:

View the site here

This comment will be updated on new commits.

@moosebuild
Copy link
Contributor

moosebuild commented Oct 31, 2024

Job Coverage, step Generate coverage on 0e9f3d9 wanted to post the following:

Framework coverage

Coverage did not change

Modules coverage

Heat transfer

af6bed #28982 0e9f3d
Total Total +/- New
Rate 88.76% 88.81% +0.05% 97.50%
Hits 4375 4404 +29 39
Misses 554 555 +1 1

Diff coverage report

Full coverage report

Full coverage reports

Reports

This comment will be updated on new commits.

@gambka gambka force-pushed the gap_perfect_conductance branch from 81b1e02 to 26b6e2f Compare October 31, 2024 22:02
Copy link
Member

@lindsayad lindsayad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for moving this upstream @gambka !

@GiudGiud GiudGiud self-assigned this Nov 1, 2024
@gambka gambka force-pushed the gap_perfect_conductance branch from 26b6e2f to f075647 Compare November 4, 2024 19:25
Copy link
Member

@lindsayad lindsayad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my comments have been addressed

@GiudGiud GiudGiud force-pushed the gap_perfect_conductance branch from f075647 to 41febb3 Compare November 4, 2024 21:32
@GiudGiud GiudGiud force-pushed the gap_perfect_conductance branch from 41febb3 to 0e9f3d9 Compare November 4, 2024 21:34
@GiudGiud
Copy link
Contributor

GiudGiud commented Nov 4, 2024

renamed a file to avoid a doco failure

@gambka
Copy link
Contributor Author

gambka commented Nov 4, 2024

renamed a file to avoid a doco failure

I have a BISON patch ready and just needs to be merged that should avoid doco failures and not need any renames.

@GiudGiud
Copy link
Contributor

GiudGiud commented Nov 4, 2024

feel free to revert if you want

@GiudGiud
Copy link
Contributor

GiudGiud commented Nov 4, 2024

otherwise it's fine as it is

@gambka
Copy link
Contributor Author

gambka commented Nov 4, 2024

The BISON change was merged into devel which should fix the failure on multiple files registering GapPerfectConductance showing in the Internal App Testing. We may need to wait until it gets into master before it can be invalidated here.

@gambka
Copy link
Contributor Author

gambka commented Nov 5, 2024

The necessary patch to BISON has made its way into master. I think the HPC failure will be unable to overcome until Sawtooth returns to service.

@moosebuild
Copy link
Contributor

Job Test HPC on 0e9f3d9 : invalidated by @lindsayad

@lindsayad lindsayad merged commit facbaef into idaholab:next Nov 5, 2024
51 checks passed
@dschwen
Copy link
Member

dschwen commented Nov 5, 2024

This looks like migrating technical debt from Bison to MOOSE. In the long term I'd rather fix our Contact action system to allow the use of mortar based thermal contact without mechanical contact.

@gambka
Copy link
Contributor Author

gambka commented Nov 5, 2024

This looks like migrating technical debt from Bison to MOOSE. In the long term I'd rather fix our Contact action system to allow the use of mortar based thermal contact without mechanical contact.

I agree with your long term goal. We also need to enable mortar contact to work on 1D simulations like the test included here that has node to node contact. What would be the reduced order mesh be used for mortar in these cases?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move GapPerfectConductance from BISON to MOOSE
5 participants