Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent Module Imports #42

Closed
10 tasks done
PaulTalbot-INL opened this issue Apr 6, 2017 · 4 comments · Fixed by #1784
Closed
10 tasks done

Consistent Module Imports #42

PaulTalbot-INL opened this issue Apr 6, 2017 · 4 comments · Fixed by #1784

Comments

@PaulTalbot-INL
Copy link
Collaborator

PaulTalbot-INL commented Apr 6, 2017


Issue Description

What did you expect to see happen?

Consistent, modular imports throughout RAVEN

What did you see instead?

Fiddling with PYTHONPATH and some inconsistency in when some modules can import others safely, as well as occasional imports in the body of python modules

Do you have a suggested fix for the development team?

We should probably continue towards making RAVEN more library-like, so that our imports all happen in a consistent way.


For Devs: Issue Review

  • 1. Is it tagged with a type: defect or improvement? tagged
  • 2. Is it tagged with a priority: critical, normal or minor? tagged
  • 3. If it will impact requirements or requirements tests, is it tagged with requirements? n/a
  • 4. If it is a defect, can it cause wrong results for users? If so an email needs to be sent to the users. n/a
  • 5. Is a rationale provided? (Such as explaining why the improvement is needed or why current code is wrong.) provided

For Devs: Issue Closure

  • 1. If the issue is a defect, is the defect fixed?
  • 2. If the issue is a defect, is the defect tested for in the regression test system? (If not explain why not.)
  • 3. If the issue can impact users, has an email to the users group been written (the email should specify if the defect impacts stable or master)?
  • 4. If the issue is a defect, does it impact the latest stable branch? If yes, is there any issue tagged with stable (create if needed)?
  • 5. If the issue is being closed without a merge request, has an explanation of why it is being closed been provided?
@joshua-cogliati-inl
Copy link
Contributor

Note that when this is fixed, we can probably add some useful checks to the pylint checks in developer_tools/pylint_list and developer_tools/pylint_check

This was referenced Apr 7, 2017
This was referenced Apr 8, 2017
@alfoa alfoa mentioned this issue Apr 21, 2017
8 tasks
@maljovec maljovec mentioned this issue Apr 21, 2017
8 tasks
@alfoa alfoa mentioned this issue Apr 24, 2017
8 tasks
@gianfabi gianfabi mentioned this issue May 2, 2017
8 tasks
@alfoa alfoa mentioned this issue Jul 25, 2024
9 tasks
@aadeshINL aadeshINL mentioned this issue Aug 14, 2024
9 tasks
@wangcj05 wangcj05 mentioned this issue Aug 17, 2024
9 tasks
@wangcj05 wangcj05 mentioned this issue Aug 28, 2024
9 tasks
@joshua-cogliati-inl joshua-cogliati-inl mentioned this issue Sep 9, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants