Adding constrained sensing capabilities to the SPSL post processor. Added a test_SPSL_constrained xml for testing. #2346

niharika2999 · 2024-07-29T19:39:35Z

Pull Request Description

What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)

Closes #2347

What are the significant changes in functionality due to this change request?

For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

1. Review all computer code.
2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
4. Automated Tests should pass, including run_tests, pylint, manual building and xsd tests. If there are changes to Simulation.py or JobHandler.py the qsub tests must pass.
5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options. Multiple short tests are preferred over one large test. If new development on the internal JobHandler parallel system is performed, a cluster test must be added setting, in XML block, the node <internalParallel> to True.
6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change. The requirements and the requirements test shall be in sync.
7. The merge request must reference an issue. If the issue is closed, the issue close checklist shall be done.
8. If an analytic test is changed/added is the the analytic documentation updated/added?
9. If any test used as a basis for documentation examples (currently found in raven/tests/framework/user_guide and raven/docs/workshop) have been changed, the associated documentation must be reviewed and assured the text matches the example.

joshua-cogliati-inl · 2024-07-29T21:18:50Z

I believe this uses features in sparsesensing that are not yet in a released version, so besides any other work that needs to be done, this should not be merged until the sparsesensing release comes out.

…9/raven into SPSL_add_constraints Need for testing

…whitespace changes to Sparsesensing.py

moosebuild · 2024-08-01T16:14:28Z

Job Test mac on d2dc13b : invalidated by @joshua-cogliati-inl

failed in fetch

joshua-cogliati-inl · 2024-08-01T16:15:08Z

Job Test mac on d2dc13b : invalidated by @joshua-cogliati-inl

failed in fetch

Opps, actually failed in set python environment.

joshua-cogliati-inl

Here are some comments for your consideration.

joshua-cogliati-inl · 2024-08-01T21:14:45Z

doc/workshop/SparseSensing/exercises/testSPSLOptiTwist.xml

      <Output class="DataObjects" type="DataSet">outPP</Output>
    </PostProcess>
    <IOStep name="print">
-      <Input class="DataObjects" type="DataSet">outPP</Input>
+      <Input class="DataObjects" type="DataSet">outPP</Input>cd 


Is cd a typo?

Yes! Thank you for catching that. I have removed cd.

joshua-cogliati-inl · 2024-08-01T21:17:19Z

ravenframework/Models/PostProcessors/SparseSensing.py

+    goal.addSub(xValue)
+    yValue = InputData.parameterInputFactory("yValue", contentType=InputTypes.StringListType,
+                                                printPriority=108,
+                                                descr=r"""Variable plotted on the Y-axis of the data model""")  ##Do we want another Z-value


Hm, do we want a zValue?

Yes! In case we have 3D data! Thank you for catching that!

joshua-cogliati-inl · 2024-08-01T21:20:53Z

ravenframework/Models/PostProcessors/SparseSensing.py

+                                                           printPriority=108,
+                                                           descr=r"""X coordinate of the focus of the parabola""")
+    goal.addSub(a)
+    xy_coords = InputData.parameterInputFactory("xy_coords", contentType=InputTypes.IntegerListType,   ##What is the type for an array?


Hm, some of the comments like "What is the type for an array?" look like they may be out of date.

joshua-cogliati-inl · 2024-08-01T21:34:54Z

ravenframework/Models/PostProcessors/SparseSensing.py

    self.sampleTag = 'RAVEN_sample_ID'                       # The sample tag
+    self.center_x = None                                     # The x co-ordinate of center of circle,ellipse


Hm, it looks like this only supports one Constrained Region? I think PySensors supports multiple constrained regions?

joshua-cogliati-inl · 2024-08-01T21:35:39Z

ravenframework/Models/PostProcessors/SparseSensing.py

+      ## TODO: Add GQR for constrained optimization
+      elif self.optimizer.lower() == 'gqr':
+        optimizer = ps.optimizers.GQR()
+      ## TODO: Add CCQR for cost constrained optimization


Do any of these TODO's need to be fixed?

joshua-cogliati-inl · 2024-08-01T21:45:55Z

tests/framework/PostProcessors/SparseSensing/testSPSLOptiTwistConstraints.xml

@@ -0,0 +1,136 @@
+<?xml version="1.0" ?>


This file does not seem to be used in the tests yet.

It looks like new tests have been added, so maybe this file can be removed?

…'cd' in the workshop test

Jimmy-INL · 2024-08-04T00:37:54Z

tests/framework/PostProcessors/SparseSensing/testSPSLOptiTwistConstraints.xml

+        <constraintOption>"exact_n"</constraintOption>
+        <ConstrainedRegions type = "circle"> 
+          <center_x></center_x>  #center coordinates instead (x,y) (r, \theta)
+          <center_y></center_y>   


Comments in xml are done using 
center_x and center_y seems not to be recognized

Jimmy-INL · 2024-08-04T00:39:37Z

tests/framework/PostProcessors/SparseSensing/tests

+    image = 'classificationOptiTwist/mySensorPlot_scatter-scatter.png classificationOptiTwist/mySensorPlot3D_scatter.png'
+    required_libraries = 'imageio'
+    rel_err = 0.01
+  [../]


This will only review the image with a relative error of 0.01 which is too small for image comparison. We need to test the csv and the image. rel_err for image can be 0.1

…nd polygon constraints

moosebuild · 2024-08-19T18:03:48Z

Job Test qsubs sawtooth on cfba5ed : invalidated by @niharika2999

moosebuild · 2024-08-19T18:33:56Z

Job Test qsubs sawtooth on cfba5ed : invalidated by @wangcj05

joshua-cogliati-inl · 2024-08-30T14:07:21Z

tests/framework/PostProcessors/SparseSensing/reconstructionConstraintsCircleOptiTwist/.DS_Store

.DS_Store and .ravenStatus should be removed from the pull request.

joshua-cogliati-inl · 2024-08-30T14:08:45Z

...s/framework/PostProcessors/SparseSensing/reconstructionConstraintsPolygonOptiTwist/outPP.csv

Should this be a gold file? (Also for the other outPP.csv files)

Jimmy-INL and others added 7 commits November 5, 2023 10:06

starting classification

5055f61

adding classification data

32f6a5c

hard coding the labels for now till we decide on naming

8a1b5d5

adding the state variable and remove the hard coding

66b4adf

adding test and golded files

226b5a8

Adding modified SPSL with constraints

53c72e3

Adding test file for constraints SPSL

3c19e83

joshua-cogliati-inl added the Do Not Merge label Jul 29, 2024

niharika2999 requested a review from Jimmy-INL July 29, 2024 21:23

Niharika Karnik and others added 11 commits July 29, 2024 16:00

Merge branch 'SPSL_add_constraints' of https://github.com/niharika299…

9c435e0

…9/raven into SPSL_add_constraints Need for testing

Adding path the pysensors branch for constraints in dependencies and …

a092359

…whitespace changes to Sparsesensing.py

deleting trailing whitespaces in the file SparseSensing.py

047fdf1

Removing git+ from dependencies as the library handler adds git+

357a16a

Fixing constrainedRegion being None error

bd72312

Changing variable name target to measuredState in the workshop SPSL test

4dbfa69

Fixing constrainedRegions Typo

4a71208

Fixing missing else statement for ConstrainedRegions

5a55ae4

Fixing error by including _ConstrainedRegionsType= None

207b0cf

Adding the test from workshop with target changed to measuredState

b59e4d0

Changing target to measuredState in the workshop inputs folder

d2dc13b

joshua-cogliati-inl reviewed Aug 1, 2024

View reviewed changes

niharika2999 added 3 commits August 2, 2024 11:15

Updating documentation for the sparse sensing postprocessor

a288140

Fixing \_n issues for max_n and exact_n in the documentation

fb43bec

Adding \_ to the documentation inside xml node and removing the typo …

26284ee

…'cd' in the workshop test

Jimmy-INL reviewed Aug 4, 2024

View reviewed changes

Changing xy_coords in the documentation

3f7b970

niharika2999 added 14 commits August 5, 2024 14:37

Adding doc, changes to SparseSensing.py and tests for each shape

60517e5

Fixing .csv to ./csv in the tests

ef79d99

Adding the folders that contain csv data in tests for the constraints

a4a1159

Changes to xml's

b6d4a9d

Fixing xml and adding missed line test

aa0a10a

Changes to the SparseSensing postprocessor

b31c4fa

Changes to the SparseSensing postprocessor

44b71f7

Trying to remove whitespace

bf3d244

Deleting trailing whitespace

d09da7e

Fixed Sparsesesning postprocessor

dbb792d

Adding working SparseSensing

c6d40b4

Almost finished SparseSensing.py and gold files for circle, ellipse a…

4618f3d

…nd polygon constraints

Adding files for gold folder in tests

0377df7

Changing cloudpickle dependency from2.2 to 3.0

cfba5ed

joshua-cogliati-inl reviewed Aug 30, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding constrained sensing capabilities to the SPSL post processor. Added a test_SPSL_constrained xml for testing. #2346

Adding constrained sensing capabilities to the SPSL post processor. Added a test_SPSL_constrained xml for testing. #2346

niharika2999 commented Jul 29, 2024 •

edited

Loading

joshua-cogliati-inl commented Jul 29, 2024

moosebuild commented Aug 1, 2024

joshua-cogliati-inl commented Aug 1, 2024

joshua-cogliati-inl left a comment

joshua-cogliati-inl Aug 1, 2024

niharika2999 Aug 2, 2024

joshua-cogliati-inl Aug 1, 2024

niharika2999 Aug 1, 2024

joshua-cogliati-inl Aug 1, 2024

joshua-cogliati-inl Aug 1, 2024

joshua-cogliati-inl Aug 1, 2024

joshua-cogliati-inl Aug 1, 2024

joshua-cogliati-inl Aug 30, 2024

Jimmy-INL Aug 4, 2024

Jimmy-INL Aug 4, 2024

moosebuild commented Aug 19, 2024

moosebuild commented Aug 19, 2024

joshua-cogliati-inl Aug 30, 2024

joshua-cogliati-inl Aug 30, 2024

		self.sampleTag = 'RAVEN_sample_ID' # The sample tag
		self.center_x = None # The x co-ordinate of center of circle,ellipse

Adding constrained sensing capabilities to the SPSL post processor. Added a test_SPSL_constrained xml for testing. #2346

Are you sure you want to change the base?

Adding constrained sensing capabilities to the SPSL post processor. Added a test_SPSL_constrained xml for testing. #2346

Conversation

niharika2999 commented Jul 29, 2024 • edited Loading

Pull Request Description

What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)

What are the significant changes in functionality due to this change request?

For Change Control Board: Change Request Review

joshua-cogliati-inl commented Jul 29, 2024

moosebuild commented Aug 1, 2024

joshua-cogliati-inl commented Aug 1, 2024

joshua-cogliati-inl left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

moosebuild commented Aug 19, 2024

moosebuild commented Aug 19, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

niharika2999 commented Jul 29, 2024 •

edited

Loading