Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add regression tests for all models #53

Open
7 of 10 tasks
GiudGiud opened this issue Dec 1, 2021 · 0 comments
Open
7 of 10 tasks

Add regression tests for all models #53

GiudGiud opened this issue Dec 1, 2021 · 0 comments
Labels
model_testing Adding new tests, enabling more existing ones, adjusting others for runtime / concerns

Comments

@GiudGiud
Copy link
Collaborator

GiudGiud commented Dec 1, 2021 •
edited
Loading

Syntax checks are a good start, but they dont prevent the models from breaking
Even a RunApp which actually runs the input will not prevent erroneous results. Only comparisons to known data points are robust enough. These are unfortunately too expensive for most inputs, so only a few time steps will be compared. And only using CSV output to avoid large files in the repository

  • MSFR Griffin-Pronghorn
  • MSFR Nek (too expensive?)
  • MSRE SAM
  • PBMR-400
  • mHTGR SAM
  • FHR Griffin-Pgh
  • FHR Nek (too expensive?)
  • FHR SAM
  • mrad (coupled multiphysics excluded for now, too expensive)
  • SFR griffin-bison
GiudGiud added a commit that referenced this issue Feb 18, 2022
@GiudGiud
Add regression testing for PBMR inputs, refs #53
3b4949f
GiudGiud added a commit that referenced this issue Feb 18, 2022
@GiudGiud
Add regression testing for MRAD model, refs #53
7822313
GiudGiud added a commit that referenced this issue Feb 19, 2022
@GiudGiud
Add regression testing for MRAD model, refs #53
173506f 
Address test failures (timeout on bison model for mrad, forgot a csv for HPMR, scaleaux in pgh test for HPMR)
GiudGiud added a commit that referenced this issue Feb 19, 2022
@GiudGiud
Add regression testing for MRAD model, refs #53
713eb2a 
Address test failures (timeout on bison model for mrad, forgot a csv for HPMR, scaleaux in pgh test for HPMR)
GiudGiud added a commit that referenced this issue Feb 19, 2022
@GiudGiud
Add regression testing for MRAD model, refs #53
f2457fe 
Address test failures (timeout on bison model for mrad, forgot a csv for HPMR, scaleaux in pgh test for HPMR)
GiudGiud added a commit that referenced this issue Feb 19, 2022
@GiudGiud
Add regression testing for MRAD model, refs #53
7b81386 
Address test failures (timeout on bison model for mrad, forgot a csv for HPMR, scaleaux in pgh test for HPMR)
GiudGiud added a commit that referenced this issue Feb 19, 2022
@GiudGiud
Add regression testing for MRAD model, refs #53
3c7a225 
Address test failures (timeout on bison model for mrad, forgot a csv for HPMR, scaleaux in pgh test for HPMR)
Revert to still using two tests for msre SAM model, as BC diffs with SAM
Dont use FenixApp in PBMR inputs, BlueCrab doesnt know what that is
Use the single physics steady calculations as restart for the single physics transients in PBMR, allowing for full restart
GiudGiud added a commit that referenced this issue Feb 21, 2022
@GiudGiud
Add regression testing for MRAD model, refs #53
1384b65 
Address test failures (timeout on bison model for mrad, forgot a csv for HPMR, scaleaux in pgh test for HPMR)
Revert to still using two tests for msre SAM model, as BC diffs with SAM
Dont use FenixApp in PBMR inputs, BlueCrab doesnt know what that is
Use the single physics steady calculations as restart for the single physics transients in PBMR, allowing for full restart
Fix the elemental auxkernel (INSCourant) being used on an auxvaraibles
GiudGiud added a commit that referenced this issue Feb 21, 2022
@GiudGiud
Add regression testing for MRAD model, refs #53
928111a 
Address test failures (timeout on bison model for mrad, forgot a csv for HPMR, scaleaux in pgh test for HPMR)
Revert to still using two tests for msre SAM model, as BC diffs with SAM
Dont use FenixApp in PBMR inputs, BlueCrab doesnt know what that is
Use the single physics steady calculations as restart for the single physics transients in PBMR, allowing for full restart
Fix the elemental auxkernel (INSCourant) being used on an auxvaraibles
GiudGiud added a commit that referenced this issue Feb 22, 2022
@GiudGiud
Add regression testing for MRAD model, refs #53
96d77de 
Address test failures (timeout on bison model for mrad, forgot a csv for HPMR, scaleaux in pgh test for HPMR)
Revert to still using two tests for msre SAM model, as BC diffs with SAM
Dont use FenixApp in PBMR inputs, BlueCrab doesnt know what that is
Use the single physics steady calculations as restart for the single physics transients in PBMR, allowing for full restart
Fix the elemental auxkernel (INSCourant) being used on an auxvaraibles
Update BC submodule, refs #0
GiudGiud added a commit that referenced this issue Feb 22, 2022
@GiudGiud
Add regression testing for PBMR inputs, refs #53
a3d6046
GiudGiud added a commit that referenced this issue Feb 22, 2022
@GiudGiud
Add regression testing for MRAD model, refs #53
e561cc8 
Address test failures (timeout on bison model for mrad, forgot a csv for HPMR, scaleaux in pgh test for HPMR)
Revert to still using two tests for msre SAM model, as BC diffs with SAM
Dont use FenixApp in PBMR inputs, BlueCrab doesnt know what that is
Use the single physics steady calculations as restart for the single physics transients in PBMR, allowing for full restart
Fix the elemental auxkernel (INSCourant) being used on an auxvaraibles
Update BC submodule, refs #0
GiudGiud added a commit that referenced this issue Feb 22, 2022
@GiudGiud
Add regression testing for MRAD model, refs #53
3335893 
Address test failures (timeout on bison model for mrad, forgot a csv for HPMR, scaleaux in pgh test for HPMR)
Revert to still using two tests for msre SAM model, as BC diffs with SAM
Dont use FenixApp in PBMR inputs, BlueCrab doesnt know what that is
Use the single physics steady calculations as restart for the single physics transients in PBMR, allowing for full restart
Fix the elemental auxkernel (INSCourant) being used on an auxvaraibles
Update BC submodule, refs #0
GiudGiud added a commit that referenced this issue Feb 24, 2022
@GiudGiud
Speed-up mrad BISON test by removing exodus output and using distribu…
78b8938 
…ted mesh, refs #53
@GiudGiud GiudGiud mentioned this issue Feb 24, 2022
Merged
GiudGiud added a commit that referenced this issue May 28, 2022
@GiudGiud
Remove special BlueCrab test using --app command line option for FHR …
a3443b1 
…SAM inputs, add regression test. refs #53
GiudGiud added a commit that referenced this issue May 28, 2022
@GiudGiud
Add regression tests for the SFR assembly model, refs #53
6382c1c
GiudGiud added a commit that referenced this issue May 28, 2022
@GiudGiud
fixup! Remove special BlueCrab test using --app command line option f…
4b5f189 
…or FHR SAM inputs, add regression test. refs #53
GiudGiud added a commit that referenced this issue May 28, 2022
@GiudGiud
Remove special BlueCrab test using --app command line option for FHR …
aa3b7fd 
…SAM inputs, add regression test. refs #53
GiudGiud added a commit that referenced this issue May 28, 2022
@GiudGiud
Add regression tests for the SFR assembly model, refs #53
4ad6001
GiudGiud added a commit that referenced this issue May 28, 2022
@GiudGiud
Remove special BlueCrab test using --app command line option for FHR …
f4fef32 
…SAM inputs, add regression test. refs #53
GiudGiud added a commit that referenced this issue May 28, 2022
@GiudGiud
Add regression tests for the SFR assembly model, refs #53
d4fc983
GiudGiud added a commit that referenced this issue May 28, 2022
@GiudGiud
Add regression tests for the SFR assembly model, refs #53
cea6cbf
@GiudGiud GiudGiud added the model_testing Adding new tests, enabling more existing ones, adjusting others for runtime / concerns label Oct 1, 2023
GiudGiud added a commit that referenced this issue Oct 7, 2023
@GiudGiud
Fix FHR test spec to run in opt, refs #53
37c9881
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
model_testing Adding new tests, enabling more existing ones, adjusting others for runtime / concerns
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@GiudGiud