Updated to support the new deps #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ome(), _.zipObject() doesn't work the same as in v3 so replaced with a reduce, _.extend() doesn't work on Arrays so changed to concat. Add some checks for undefined to stop errors on the first digest. Fixed the examples. The examples don't use the bower dependencies because they use a CDN, that was a gotcha until I realised.
…s, update the example to list which deps you need
tomsaleeba
pushed a commit
to tomsaleeba/angular-dc
that referenced
this pull request
Aug 29, 2017
Features/mm/node require fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure where to PR to but seeing as I forked from your repo, it seems logical to PR back to you.
I've got the code working with lodash v4 and fixed up the examples:
https://tomsaleeba.github.io/angular-dc/example/stocks/pie.html
https://tomsaleeba.github.io/angular-dc/example/stocks/nasdaq.html